Remove unneeded with_items usage for clarity

Using with_items with a single item makes the
tasks overly complex to read/maintain

Change-Id: Ib7f6e4854e8b369f0331751a89883dc857b8f5a5
This commit is contained in:
Travis Truman 2016-04-20 11:54:55 -04:00
parent 21d01e864a
commit 06dc9beff1
2 changed files with 8 additions and 14 deletions

View File

@ -52,22 +52,18 @@
rabbitmq_servers: "{{ servers.sorted_list }}"
- name: Create log dir
file:
path: "{{ item.path }}"
path: "/openstack/log/{{ inventory_hostname }}-designate"
state: directory
with_items:
- { path: "/openstack/log/{{ inventory_hostname }}-designate" }
when: is_metal | bool
tags:
- designate-logs
- designate-log-dirs
- name: Create log aggregation links
file:
src: "{{ item.src }}"
dest: "{{ item.dest }}"
state: "{{ item.state }}"
src: "/openstack/log/{{ inventory_hostname }}-designate"
dest: "/var/log/designate"
state: "link"
force: "yes"
with_items:
- { src: "/openstack/log/{{ inventory_hostname }}-designate", dest: "/var/log/designate", state: "link" }
when: is_metal | bool
tags:
- designate-logs

View File

@ -78,13 +78,11 @@
- name: Create designate log dir
file:
path: "{{ item.path }}"
path: "/var/log/designate"
state: directory
owner: "{{ item.owner|default(designate_system_user_name) }}"
group: "{{ item.group|default(designate_system_group_name) }}"
mode: "{{ item.mode|default('0755') }}"
with_items:
- { path: "/var/log/designate" }
owner: "{{ designate_system_user_name }}"
group: "{{ designate_system_group_name }}"
mode: "0755"
when: log_dir.rc != 0
tags:
- designate-dirs