From 59621889ccf336ab0567f27285cd4f0b12afe4bb Mon Sep 17 00:00:00 2001
From: Dmitriy Rabotyagov <dmitriy.rabotyagov@citynetwork.eu>
Date: Fri, 11 Sep 2020 15:45:19 +0300
Subject: [PATCH] Define condition for the first play host one time

We use the same condition, which defines against what host some "service"
tasks should run against, several times. It's hard to keep it the same
across the role and ansible spending additional resources to evaluate
it each time, so it's simpler and better for the maintenance to set
a boolean variable which will say for all tasks, that we want to run
only against signle host, if they should run or not now.

Change-Id: I63e9f830f086763f3dcb90cd54dbdebcfc679b1c
---
 tasks/main.yml | 10 ++++------
 vars/main.yml  |  2 ++
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tasks/main.yml b/tasks/main.yml
index e9afdaa..a860727 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -41,8 +41,7 @@
 
 - import_tasks: db_setup.yml
   when:
-    - "designate_services['designate-api']['group'] in group_names"
-    - "inventory_hostname == ((groups[designate_services['designate-api']['group']]| intersect(ansible_play_hosts)) | list)[0]"
+    - "_designate_is_first_play_host"
   vars:
     _oslodb_setup_host: "{{ designate_db_setup_host }}"
     _oslodb_databases:
@@ -56,8 +55,7 @@
 
 - import_tasks: mq_setup.yml
   when:
-    - "designate_services['designate-api']['group'] in group_names"
-    - "inventory_hostname == ((groups[designate_services['designate-api']['group']]| intersect(ansible_play_hosts)) | list)[0]"
+    - "_designate_is_first_play_host"
   vars:
     _oslomsg_rpc_setup_host: "{{ designate_oslomsg_rpc_setup_host }}"
     _oslomsg_rpc_userid: "{{ designate_oslomsg_rpc_userid }}"
@@ -110,7 +108,7 @@
   meta: flush_handlers
 
 - import_tasks: designate_db_sync.yml
-  when: inventory_hostname == groups['designate_all'][0]
+  when: _designate_is_first_play_host
   tags:
     - designate-install
 
@@ -140,7 +138,7 @@
       - name: "{{ designate_service_name }}"
         type: "{{ designate_service_type }}"
         description: "{{ designate_service_description }}"
-  when: inventory_hostname == groups['designate_all'][0]
+  when: _designate_is_first_play_host
   tags:
     - designate-install
 
diff --git a/vars/main.yml b/vars/main.yml
index 46d02cc..06b1187 100644
--- a/vars/main.yml
+++ b/vars/main.yml
@@ -13,6 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+_designate_is_first_play_host: "{{ (designate_services['designate-api']['group'] in group_names and inventory_hostname == (groups[designate_services['designate-api']['group']] | intersect(ansible_play_hosts)) | first) | bool }}"
+
 #
 # Compile a list of the services on a host based on whether
 # the host is in the host group and the service is enabled.