openstack/openstack-ansible-os_designate
Code Issues Proposed changes

Role cleanup

Browse Source 
This commit does the following:

- updates README.rst by adding some required vars and removing some
  references to glance
- pips ansible-lint as is done in the other roles
- updates tests/test-prepare-host.yml to install specified packages
  outside of tox's venv

Change-Id: I80f36b1e5584895681b6c51f5b1e329794b4c92a
This commit is contained in:
Matt Thompson 2016-03-17 10:03:15 +00:00
parent a07a073cc1
commit f926a74c61
3 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.rst
View File

@ -11,8 +11,6 @@ This role will install the following Upstart services:
* designate-pool-manager * designate-pool-manager
* designate-mdns * designate-mdns
* designate-sink * designate-sink
* glance-api
* glance-registry
Default Variables Default Variables
================= =================
@ -28,7 +26,9 @@ Required Variables
designate_galera_address designate_galera_address
designate_container_mysql_password designate_container_mysql_password
designate_pool_manager_container_mysql_password
designate_service_password designate_service_password
designate_rabbitmq_password
Example Playbook Example Playbook
================ ================
@ -45,5 +45,7 @@ Example Playbook
internal_lb_vip_address: 192.168.0.1 internal_lb_vip_address: 192.168.0.1
designate_galera_address: "{{ internal_lb_vip_address }}" designate_galera_address: "{{ internal_lb_vip_address }}"
designate_container_mysql_password: "SuperSecretePassword1" designate_container_mysql_password: "SuperSecretePassword1"
designate_service_password: "SuperSecretePassword2" designate_pool_manager_container_mysql_password: "SuperSecretePassword2"
designate_service_password: "SuperSecretePassword3"
designate_rabbitmq_password: "SuperSecretePassword4"

2
test-requirements.txt
View File

@ -1,4 +1,4 @@
ansible-lint ansible-lint<=2.3.9
ansible>=1.9.1,<2.0.0 ansible>=1.9.1,<2.0.0
bashate bashate
flake8 flake8

8
tests/test-prepare-host.yml
View File

@ -44,11 +44,11 @@
chroot_path: trusty/rootfs-amd64 chroot_path: trusty/rootfs-amd64
- role: "openstack_openrc" - role: "openstack_openrc"
post_tasks: post_tasks:
# In the gate these packages get installed into .tox/functional, which is
# not where we need them to be. If we can figure out how to override this
# we can revert to using the pip module instead.
- name: Install pip packages - name: Install pip packages
pip: command: /usr/local/bin/pip install {{ item }}
name: "{{ item }}"
state: present
extra_args: "{{ pip_install_options|default('') }}"
register: install_packages register: install_packages
until: install_packages|success until: install_packages|success
retries: 5 retries: 5