From 0e3476b0122dc94d64acf730bc670f94e4781dab Mon Sep 17 00:00:00 2001
From: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>
Date: Tue, 15 May 2018 08:25:19 +0100
Subject: [PATCH] Move database creation into role

There is no record for why we implement the database creation outside
of the role in the playbook, when we could do it inside the role.

Implementing it inside the role allows us to reduce the quantity of
group_vars duplicated from the role, and allows us to better document
the required variables in the role. The delegation can still be done
as it is done in the playbook too.

In this patch we implement a new variable called 'glance_db_setup_host'
which is used in the role to allow delegation of the database setup
task to any host, but defaults to the first member of the galera_all
host group. We also document the variable glance_galera_address which
has been used for a long time, but never documented.

Needed-By: https://review.openstack.org/568485
Needed-By: https://review.openstack.org/568492
Change-Id: I1a875cfdece088838027fc7b4dafd812d8c2693b
---
 defaults/main.yml         |  2 ++
 examples/playbook.yml     |  4 ++++
 tasks/glance_db_setup.yml | 26 ++++++++++++++++++++++++++
 3 files changed, 32 insertions(+)

diff --git a/defaults/main.yml b/defaults/main.yml
index da9d23cf..edbd8082 100644
--- a/defaults/main.yml
+++ b/defaults/main.yml
@@ -106,6 +106,8 @@ glance_rabbitmq_telemetry_servers: "{{ glance_rabbitmq_servers }}"
 glance_rabbitmq_telemetry_use_ssl: "{{ glance_rabbitmq_use_ssl }}"
 
 ## Database info
+glance_db_setup_host: "{{ ('galera_all' in groups) | ternary(groups['galera_all'][0], 'localhost') }}"
+glance_galera_address: "{{ galera_address | default('127.0.0.1') }}"
 glance_galera_database: glance
 glance_galera_user: glance
 glance_galera_use_ssl: "{{ galera_use_ssl | default(False) }}"
diff --git a/examples/playbook.yml b/examples/playbook.yml
index 2d4ff578..a43e31c5 100644
--- a/examples/playbook.yml
+++ b/examples/playbook.yml
@@ -7,3 +7,7 @@
     external_lb_vip_address: 172.16.24.1
     internal_lb_vip_address: 192.168.0.1
     glance_galera_address: "{{ internal_lb_vip_address }}"
+    galera_root_user: root
+  vars_prompt:
+    - name: "galera_root_password"
+      prompt: "What is galera_root_password?"
diff --git a/tasks/glance_db_setup.yml b/tasks/glance_db_setup.yml
index d9a66e91..c633094d 100644
--- a/tasks/glance_db_setup.yml
+++ b/tasks/glance_db_setup.yml
@@ -13,6 +13,32 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+- name: Create DB for service
+  mysql_db:
+    login_user: "{{ galera_root_user }}"
+    login_password: "{{ galera_root_password }}"
+    login_host: "{{ glance_galera_address }}"
+    name: "{{ glance_galera_database }}"
+    state: "present"
+  delegate_to: "{{ glance_db_setup_host }}"
+  no_log: True
+
+- name: Grant access to the DB for the service
+  mysql_user:
+    login_user: "{{ galera_root_user }}"
+    login_password: "{{ galera_root_password }}"
+    login_host: "{{ glance_galera_address }}"
+    name: "{{ glance_galera_user }}"
+    password: "{{ glance_container_mysql_password }}"
+    host: "{{ item }}"
+    state: "present"
+    priv: "{{ glance_galera_database }}.*:ALL"
+  delegate_to: "{{ glance_db_setup_host }}"
+  with_items:
+    - "localhost"
+    - "%"
+  no_log: True
+
 - name: Perform a Glance DB sync
   command: "{{ glance_bin }}/glance-manage db_sync"
   become: yes