Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: If3a68d50f07711b4dff101dda1c5c997e46e71d2

defaults/main.yml

@@ -16,9 +16,10 @@
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 glance_package_state: "latest"
+glance_pip_package_state: "latest"
 
 glance_git_repo: https://git.openstack.org/openstack/glance
 glance_git_install_branch: master

handlers/main.yml

@@ -19,8 +19,8 @@
     - Restart glance services
 
 - name: Reload upstart init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
+  changed_when: false
   notify:
     - Restart glance services
 

tasks/glance_db_setup.yml

@@ -17,8 +17,10 @@
   command: "{{ glance_bin }}/glance-manage db_sync"
   become: yes
   become_user: "{{ glance_system_user_name }}"
+  changed_when: false
 
 - name: Load glance metadata definitions
   command: "{{ glance_bin }}/glance-manage db_load_metadefs {{ glance_etc_dir }}/metadefs"
   become: yes
   become_user: "{{ glance_system_user_name }}"
+  changed_when: false

tasks/glance_install.yml

@@ -58,7 +58,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ glance_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ glance_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -129,7 +129,7 @@
 - name: Install pip packages
   pip:
     name: "{{ glance_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ glance_pip_package_state }}"
     virtualenv: "{{ glance_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/main.yml

@@ -27,6 +27,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always