openstack/openstack-ansible-os_horizon
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false'

Browse Source 
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: I04d02d4b2b85a10e2dc715e4f68dc8b26e258504
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-10-14 16:45:27 -05:00
parent 30095eae31
commit 5abc1e2e80
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/horizon_install.yml
View File

@ -86,7 +86,7 @@
url: "{{ horizon_venv_download_url }}" url: "{{ horizon_venv_download_url }}"
dest: "/var/cache/{{ horizon_venv_download_url | basename }}" dest: "/var/cache/{{ horizon_venv_download_url | basename }}"
force: yes force: yes
ignore_errors: true failed_when: false
register: get_venv register: get_venv
when: when:
- not horizon_developer_mode | bool - not horizon_developer_mode | bool