openstack/openstack-ansible-os_ironic
Code Issues Proposed changes

Ansible 2.x - Address deprecation warning of bare variables

Browse Source 
Ansible 2.2 will not allow "bare" variable references
in with_* loops. See https://docs.ansible.com/ansible/porting_guide_2.0.html#deprecated
for details.

Change-Id: I70571efd5ff409a0a96e339a9cd6812ffd045277
This commit is contained in:
Travis Truman 2016-04-19 14:56:13 -04:00
parent 9b268e9ffc
commit b32b092ace
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
handlers/main.yml
View File

@ -18,7 +18,7 @@
name: "{{ item }}" name: "{{ item }}"
state: restarted state: restarted
pattern: "{{ item }}" pattern: "{{ item }}"
with_items: ironic_service_names with_items: "{{ ironic_service_names }}"
failed_when: false failed_when: false
- name: Restart tftpd-hpa - name: Restart tftpd-hpa

2
tasks/ironic_api_install.yml
View File

@ -21,7 +21,7 @@
until: install_packages|success until: install_packages|success
retries: 5 retries: 5
delay: 2 delay: 2
with_items: ironic_api_apt_packages with_items: "{{ ironic_api_apt_packages }}"
tags: tags:
- ironic-install - ironic-install
- ironic-api - ironic-api

4
tasks/ironic_conductor_install.yml
View File

@ -21,7 +21,7 @@
until: install_packages|success until: install_packages|success
retries: 5 retries: 5
delay: 2 delay: 2
with_items: ironic_conductor_apt_packages with_items: "{{ ironic_conductor_apt_packages }}"
tags: tags:
- ironic-install - ironic-install
- ironic-conductor - ironic-conductor
@ -35,7 +35,7 @@
until: install_packages|success until: install_packages|success
retries: 5 retries: 5
delay: 2 delay: 2
with_items: ironic_conductor_standalone_apt_packages with_items: "{{ ironic_conductor_standalone_apt_packages }}"
when: ironic_standalone when: ironic_standalone
tags: tags:
- ironic-install - ironic-install

6
tasks/ironic_install.yml
View File

@ -66,7 +66,7 @@
until: install_packages|success until: install_packages|success
retries: 5 retries: 5
delay: 2 delay: 2
with_items: ironic_requires_pip_packages with_items: "{{ ironic_requires_pip_packages }}"
tags: tags:
- ironic-install - ironic-install
- ironic-pip-packages - ironic-pip-packages
@ -183,7 +183,7 @@
until: install_packages|success until: install_packages|success
retries: 5 retries: 5
delay: 2 delay: 2
with_items: ironic_pip_packages with_items: "{{ ironic_pip_packages }}"
when: when:
- ironic_venv_enabled | bool - ironic_venv_enabled | bool
- ironic_get_venv | failed or ironic_developer_mode | bool - ironic_get_venv | failed or ironic_developer_mode | bool
@ -201,7 +201,7 @@
until: install_packages|success until: install_packages|success
retries: 5 retries: 5
delay: 2 delay: 2
with_items: ironic_pip_packages with_items: "{{ ironic_pip_packages }}"
when: when:
- not ironic_venv_enabled | bool - not ironic_venv_enabled | bool
- not ironic_developer_mode | bool - not ironic_developer_mode | bool