Merge "Execute service setup against a delegated host using Ansible built-in modules"

defaults/main.yml

@@ -18,6 +18,11 @@
 # Verbosity Options
 debug: False
 
+# Set the host which will execute the shade modules
+# for the service setup. The host must already have
+# clouds.yaml properly configured.
+ironic_service_setup_host: "{{ openstack_service_setup_host | default('localhost') }}"
+
 # Comma separated list of Glance API servers
 ironic_glance_api_servers: "{{ (glance_service_internalurl | default('http://localhost')) | netorigin }}"
 
@@ -201,11 +206,6 @@ ironic_venv_download_url: http://127.0.0.1/venvs/untagged/ubuntu/ironic.tgz
 
 ironic_tftp_server_address: "{{ ansible_host }}"
 
-ironic_requires_pip_packages:
-  - virtualenv
-  - python-keystoneclient # Keystoneclient needed for the OSA keystone lib
-  - httplib2 # for Ansible's uri module
-
 ironic_oneview_optional_pip_packages:
   - ironic-oneview-cli
   - ironic-oneviewd

meta/main.yml

@@ -32,4 +32,3 @@ dependencies:
     when:
       - ansible_pkg_mgr == 'apt'
   - galera_client
-  - openstack_openrc

releasenotes/notes/ironic-service-setup-host-658842e1875ea7bf.yaml

@@ -0,0 +1,17 @@
+---
+features:
+  - |
+    The service setup in keystone for ironic will now be executed
+    through delegation to the ``ironic_service_setup_host`` which,
+    by default, is ``localhost`` (the deploy host). Deployers can
+    opt to rather change this to the utility container by implementing
+    the following override in ``user_variables.yml``.
+
+    .. code-block:: yaml
+
+      ironic_service_setup_host: "{{ groups['utility_all'][0] }}"
+
+deprecations:
+  - |
+    The variable ``ironic_requires_pip_packages`` is no longer required
+    and has therefore been removed.

tasks/ironic_install.yml

@@ -33,19 +33,6 @@
       {% endfor %}
   when: ironic_developer_mode | bool
 
-- name: Install requires pip packages
-  pip:
-    name: "{{ ironic_requires_pip_packages }}"
-    state: "{{ ironic_pip_package_state }}"
-    extra_args: >-
-      {{ ironic_developer_mode | ternary(pip_install_developer_constraints | default('--constraint /opt/developer-pip-constraints.txt'), '') }}
-      {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
-      {{ pip_install_options | default('') }}
-  register: install_packages
-  until: install_packages|success
-  retries: 5
-  delay: 2
-
 - name: Retrieve checksum for venv download
   uri:
     url: "{{ ironic_venv_download_url | replace('tgz', 'checksum') }}"

tasks/ironic_service_setup.yml

@@ -13,83 +13,81 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# Create a service
+# We set the python interpreter to the ansible runtime venv if
-- name: Ensure ironic service
+# the delegation is to localhost so that we get access to the
-  keystone:
+# appropriate python libraries in that venv. If the delegation
-    command: "ensure_service"
+# is to another host, we assume that it is accessible by the
-    login_user: "{{ keystone_admin_user_name }}"
+# system python instead.
-    login_password: "{{ keystone_auth_admin_password }}"
+- name: Setup the service
-    login_project_name: "{{ keystone_admin_tenant_name }}"
+  delegate_to: "{{ ironic_service_setup_host }}"
-    endpoint: "{{ keystone_service_adminurl }}"
+  vars:
-    service_name: "{{ ironic_service_name }}"
+    ansible_python_interpreter: >-
-    service_type: "{{ ironic_service_type }}"
+      {{ (ironic_service_setup_host == 'localhost') | ternary(ansible_playbook_python, ansible_python['executable']) }}
-    description: "{{ ironic_service_description }}"
+  block:
-    insecure: "{{ keystone_service_adminuri_insecure }}"
+    - name: Add service to the keystone service catalog
-  register: add_service
+      os_keystone_service:
-  until: add_service|success
+        cloud: default
-  retries: 5
+        state: present
-  delay: 2
+        name: "{{ ironic_service_name }}"
-  no_log: true
+        service_type: "{{ ironic_service_type }}"
+        description: "{{ ironic_service_description }}"
+        endpoint_type: admin
+        verify: "{{ not keystone_service_adminuri_insecure }}"
+      register: add_service
+      until: add_service is success
+      retries: 5
+      delay: 10
 
-# Create an admin user
+    - name: Add service user
-- name: Ensure ironic user
+      os_user:
-  keystone:
+        cloud: default
-    command: "ensure_user"
+        state: present
-    login_user: "{{ keystone_admin_user_name }}"
+        name: "{{ ironic_service_user_name }}"
-    login_password: "{{ keystone_auth_admin_password }}"
+        password: "{{ ironic_service_password }}"
-    login_project_name: "{{ keystone_admin_tenant_name }}"
+        domain: default
-    endpoint: "{{ keystone_service_adminurl }}"
+        default_project: "{{ ironic_service_project_name }}"
-    user_name: "{{ ironic_service_user_name }}"
+        endpoint_type: admin
-    project_name: "{{ ironic_service_project_name }}"
+        verify: "{{ not keystone_service_adminuri_insecure }}"
-    password: "{{ ironic_service_password }}"
+      register: add_service
-    insecure: "{{ keystone_service_adminuri_insecure }}"
+      when: not ironic_service_in_ldap | bool
-  register: add_service
+      until: add_service is success
-  when: not ironic_service_in_ldap | bool
+      retries: 5
-  until: add_service|success
+      delay: 10
-  retries: 5
+      no_log: True
-  delay: 10
-  no_log: true
 
-# Add a role to the user
+    - name: Add service user to admin role
-- name: Ensure ironic user to admin role
+      os_user_role:
-  keystone:
+        cloud: default
-    command: "ensure_user_role"
+        state: present
-    login_user: "{{ keystone_admin_user_name }}"
+        user: "{{ ironic_service_user_name }}"
-    login_password: "{{ keystone_auth_admin_password }}"
+        role: "{{ ironic_service_role_name }}"
-    login_project_name: "{{ keystone_admin_tenant_name }}"
+        project: "{{ ironic_service_project_name }}"
-    endpoint: "{{ keystone_service_adminurl }}"
+        endpoint_type: admin
-    user_name: "{{ ironic_service_user_name }}"
+        verify: "{{ not keystone_service_adminuri_insecure }}"
-    project_name: "{{ ironic_service_project_name }}"
+      register: add_service
-    role_name: "{{ ironic_service_role_name }}"
+      when: not ironic_service_in_ldap | bool
-    insecure: "{{ keystone_service_adminuri_insecure }}"
+      until: add_service is success
-  register: add_service
+      retries: 5
-  when: not ironic_service_in_ldap | bool
+      delay: 10
-  until: add_service|success
-  retries: 5
-  delay: 10
-  no_log: true
 
-# Create an endpoint
+    - name: Add endpoints to keystone endpoint catalog
-- name: Ensure ironic endpoint
+      os_keystone_endpoint:
-  keystone:
+        cloud: default
-    command: "ensure_endpoint"
+        state: present
-    login_user: "{{ keystone_admin_user_name }}"
+        service: "{{ ironic_service_name }}"
-    login_password: "{{ keystone_auth_admin_password }}"
+        endpoint_interface: "{{ item.interface }}"
-    login_project_name: "{{ keystone_admin_tenant_name }}"
+        url: "{{ item.url }}"
-    endpoint: "{{ keystone_service_adminurl }}"
+        region: "{{ ironic_service_region }}"
-    region_name: "{{ ironic_service_region }}"
+        endpoint_type: admin
-    service_name: "{{ ironic_service_name }}"
+        verify: "{{ not keystone_service_adminuri_insecure }}"
-    service_type: "{{ ironic_service_type }}"
+      register: add_service
-    insecure: "{{ keystone_service_adminuri_insecure }}"
+      until: add_service is success
-    endpoint_list:
+      retries: 5
-      - url: "{{ ironic_service_publicurl }}"
+      delay: 10
-        interface: "public"
+      with_items:
-      - url: "{{ ironic_service_internalurl }}"
+        - interface: "public"
-        interface: "internal"
+          url: "{{ ironic_service_publicurl }}"
-      - url: "{{ ironic_service_adminurl }}"
+        - interface: "internal"
-        interface: "admin"
+          url: "{{ ironic_service_internalurl }}"
-  register: add_service
+        - interface: "admin"
-  until: add_service|success
+          url: "{{ ironic_service_adminurl }}"
-  retries: 5
-  delay: 10
-  no_log: true

tests/host_vars/localhost.yml

@@ -14,7 +14,6 @@
 # limitations under the License.
 
 neutron_local_ip:  10.1.2.1
-ansible_python_interpreter: "/usr/bin/python2"
 bridges:
   - name: "br-mgmt"
     ip_addr: "10.1.1.1"

tests/test-configure-ironic.yml

@@ -15,20 +15,13 @@
 
 - name: Setup localhost requirements
   hosts: localhost
-  become: True
+  connection: local
-  gather_facts: True
+  gather_facts: false
+  vars_files:
+    - common/test-vars.yml
+  vars:
+    ansible_python_interpreter: "{{ ansible_playbook_python }}"
   tasks:
-    - name: Install pip requirements
-      pip:
-        name: "{{ item }}"
-        state: "{{ ironic_pip_package_state }}"
-      with_items:
-        - python-neutronclient
-        - shade
-      register: install_packages
-      until: install_packages|success
-      retries: 5
-      delay: 2
     - name: Create br-prov network
       os_network:
         cloud: default
@@ -37,6 +30,7 @@
         name: "{{ ironic_neutron_provisioning_network_name }}"
         provider_network_type: flat
         provider_physical_network: prov
+
     - name: Ensure public subnet exists
       os_subnet:
         state: present
@@ -46,5 +40,3 @@
         network_name: "{{ ironic_neutron_provisioning_network_name }}"
         name: "ironic-prov-subnet"
         cidr: "10.1.6.0/24"
-  vars_files:
-    - common/test-vars.yml