From 8ec335cbfdf4f5720d5971e104ca646e9afe093c Mon Sep 17 00:00:00 2001
From: Pete Birley <pete@port.direct>
Date: Thu, 8 Jun 2017 16:38:20 -0500
Subject: [PATCH] Checks: Run the helm template plugin against charts

This PS runs the helm template plugin against charts in the linter
gate.

Change-Id: I660588707a4e2b49d9661222b590dfea67b74fb1
---
 tools/gate/funcs/helm.sh | 18 ++++++++++++++++++
 tools/gate/setup_gate.sh | 10 +++++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/tools/gate/funcs/helm.sh b/tools/gate/funcs/helm.sh
index 0aa308af11..1beb85413a 100755
--- a/tools/gate/funcs/helm.sh
+++ b/tools/gate/funcs/helm.sh
@@ -81,3 +81,21 @@ function helm_test_deployment {
   kubectl logs -n openstack ${DEPLOYMENT}-rally-test > ${LOGS_DIR}/rally/${DEPLOYMENT}
   kubectl delete -n openstack pod ${DEPLOYMENT}-rally-test
 }
+
+function helm_plugin_template_install {
+  # NOTE(portdirect): the helm plugin install command does not seem to respect the --version flag with helm 2.3.0
+  #helm plugin install https://github.com/technosophos/helm-template --version 2.3.0.1
+  TMP_DIR=$(mktemp -d)
+  curl -sSL https://github.com/technosophos/helm-template/releases/download/2.3.0%2B1/helm-template-linux-2.3.0.1.tgz | tar -zxv -C ${TMP_DIR}
+  mkdir -p ${HOME}/.helm/plugins/
+  mv ${TMP_DIR}/ ${HOME}/.helm/plugins/helm-template
+  rm -rf ${TMP_DIR}
+}
+
+function helm_template_run {
+  mkdir -p ${LOGS_DIR}/templates
+  for CHART in $(helm search | awk '{ print $1 }' | tail -n +2 | awk -F '/' '{ print $NF }'); do
+    echo "Running Helm template plugin on chart: $CHART"
+    helm template --verbose $CHART > ${LOGS_DIR}/templates/$CHART
+  done
+}
diff --git a/tools/gate/setup_gate.sh b/tools/gate/setup_gate.sh
index f3ae6986f1..2333a5e948 100755
--- a/tools/gate/setup_gate.sh
+++ b/tools/gate/setup_gate.sh
@@ -25,7 +25,7 @@ source ${WORK_DIR}/tools/gate/funcs/network.sh
 source ${WORK_DIR}/tools/gate/funcs/helm.sh
 
 # Setup the logging location: by default use the working dir as the root.
-export LOGS_DIR=${LOGS_DIR:-"${WORK_DIR}/logs/"}
+export LOGS_DIR=${LOGS_DIR:-"${WORK_DIR}/logs"}
 mkdir -p ${LOGS_DIR}
 
 # Moving the ws-linter here to avoid it blocking all the jobs just for ws
@@ -43,6 +43,14 @@ helm_install
 helm_serve
 helm_lint
 
+# In the linter, we also run the helm template plugin to get a sanity check
+# of the chart without verifying against the k8s API
+if [ "x$INTEGRATION_TYPE" == "xlinter" ]; then
+  helm_build > ${LOGS_DIR}/helm_build
+  helm_plugin_template_install
+  helm_template_run
+fi
+
 # Setup the K8s Cluster
 if [ "x$INTEGRATION" == "xaio" ]; then
  bash ${WORK_DIR}/tools/gate/kubeadm_aio.sh