From 5890ebf4f860a9b10ddb1aee4c558b72163087c0 Mon Sep 17 00:00:00 2001
From: Jean-Philippe Evrard <jean-philippe@evrard.me>
Date: Wed, 27 Feb 2019 16:25:36 +0100
Subject: [PATCH] Increase default logging

The current helm chart defaults drops logs of any warnings
(and above) for any logger outside of the namespace
of the deployed chart.

This is a problem, as logging could reveal important information for
operators. While this could be done with a value override, there
is no reason to hide warning, errors, or critical information that
are happening in the cycle of the operation of the software
deployed with the helm charts. For example, nothing would get
logged in oslo_service, which is a very important part of running
OpenStack.

This fixes it by logging to stdout all the warnings (and above)
for OpenStack apps.

Change-Id: I16f77f4cc64caf21b21c8519e6da34eaf5d31498
---
 barbican/values.yaml                                        | 2 +-
 cinder/values.yaml                                          | 2 +-
 congress/values.yaml                                        | 2 +-
 glance/values.yaml                                          | 2 +-
 heat/values.yaml                                            | 2 +-
 ironic/values.yaml                                          | 2 +-
 keystone/values.yaml                                        | 2 +-
 magnum/values.yaml                                          | 2 +-
 mistral/values.yaml                                         | 2 +-
 neutron/values.yaml                                         | 2 +-
 nova/values.yaml                                            | 2 +-
 .../notes/increase-default-logging-31db0e9d3e51b429.yaml    | 6 ++++++
 senlin/values.yaml                                          | 2 +-
 13 files changed, 18 insertions(+), 12 deletions(-)
 create mode 100644 releasenotes/notes/increase-default-logging-31db0e9d3e51b429.yaml

diff --git a/barbican/values.yaml b/barbican/values.yaml
index ab1daf3228..3493009351 100644
--- a/barbican/values.yaml
+++ b/barbican/values.yaml
@@ -467,7 +467,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_barbican:
       level: INFO
       handlers:
diff --git a/cinder/values.yaml b/cinder/values.yaml
index e225130bd3..942afa50d7 100644
--- a/cinder/values.yaml
+++ b/cinder/values.yaml
@@ -771,7 +771,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_cinder:
       level: INFO
       handlers:
diff --git a/congress/values.yaml b/congress/values.yaml
index c90d3a1bf9..cc2ec35e3d 100644
--- a/congress/values.yaml
+++ b/congress/values.yaml
@@ -386,7 +386,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_congress:
       level: INFO
       handlers:
diff --git a/glance/values.yaml b/glance/values.yaml
index aa5cf7212f..5d362f7846 100644
--- a/glance/values.yaml
+++ b/glance/values.yaml
@@ -304,7 +304,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_glance:
       level: INFO
       handlers:
diff --git a/heat/values.yaml b/heat/values.yaml
index fd02006bed..a8cadb4eaf 100644
--- a/heat/values.yaml
+++ b/heat/values.yaml
@@ -474,7 +474,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_heat:
       level: INFO
       handlers:
diff --git a/ironic/values.yaml b/ironic/values.yaml
index 40129b02a2..af39c8c628 100644
--- a/ironic/values.yaml
+++ b/ironic/values.yaml
@@ -153,7 +153,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_ironic:
       level: INFO
       handlers:
diff --git a/keystone/values.yaml b/keystone/values.yaml
index 383b861ea6..b7ee350922 100644
--- a/keystone/values.yaml
+++ b/keystone/values.yaml
@@ -927,7 +927,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_keystone:
       level: INFO
       handlers:
diff --git a/magnum/values.yaml b/magnum/values.yaml
index aaf0712a2e..2ef30c3ada 100644
--- a/magnum/values.yaml
+++ b/magnum/values.yaml
@@ -151,7 +151,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_magnum:
       level: INFO
       handlers:
diff --git a/mistral/values.yaml b/mistral/values.yaml
index afaba51513..74f4c4908c 100644
--- a/mistral/values.yaml
+++ b/mistral/values.yaml
@@ -482,7 +482,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_mistral:
       level: INFO
       handlers:
diff --git a/neutron/values.yaml b/neutron/values.yaml
index 548c7c0cc6..0f29562a97 100644
--- a/neutron/values.yaml
+++ b/neutron/values.yaml
@@ -1490,7 +1490,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_neutron:
       level: INFO
       handlers:
diff --git a/nova/values.yaml b/nova/values.yaml
index 6558182ac4..9be08f9ead 100644
--- a/nova/values.yaml
+++ b/nova/values.yaml
@@ -1526,7 +1526,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_nova:
       level: INFO
       handlers:
diff --git a/releasenotes/notes/increase-default-logging-31db0e9d3e51b429.yaml b/releasenotes/notes/increase-default-logging-31db0e9d3e51b429.yaml
new file mode 100644
index 0000000000..fabb49217d
--- /dev/null
+++ b/releasenotes/notes/increase-default-logging-31db0e9d3e51b429.yaml
@@ -0,0 +1,6 @@
+---
+other:
+  - |
+    The logging for barbican, cinder, congress, glance, heat, ironic,
+    keystone, magnum, mistral, neutron, nova, and senlin has been increased to
+    log all warnings (and above) to stdout by default.
diff --git a/senlin/values.yaml b/senlin/values.yaml
index faa5378ac9..4545cfb357 100644
--- a/senlin/values.yaml
+++ b/senlin/values.yaml
@@ -196,7 +196,7 @@ conf:
         - default
     logger_root:
       level: WARNING
-      handlers: 'null'
+      handlers: stdout
     logger_senlin:
       level: INFO
       handlers: