Update job dependency method to match existing pattern

This also moves joinWithColon to common, so a subsequent commit should remove
the _helpers.tpl template from charts which include common as a dependency.

common/templates/_funcs.tpl

@@ -1,3 +1,7 @@
+{{- define "joinListWithColon" -}}
+{{ range $k, $v := . }}{{ if $k }},{{ end }}{{ $v }}{{ end }}
+{{- end -}}
+
 {{- define "template" -}}
 {{- $name := index . 0 -}}
 {{- $context := index . 1 -}}

horizon/templates/deployment.yaml

@@ -21,7 +21,7 @@ spec:
               },
               {
                 "name": "DEPENDENCY_SERVICE",
-                "value": "memcached,keystone-api"
+                "value": "{{  include "joinListWithColon" .Values.dependencies.dashboard.service }}"
               },
               {
                 "name": "COMMAND",

horizon/values.yaml

@@ -21,6 +21,12 @@ local_settings:
   horizon_secret_key: 9aee62c0-5253-4a86-b189-e0fb71fa503c
   debug: "True"
 
+dependencies:
+  dashboard:
+    service:
+    - memcached
+    - keystone-api
+
 # typically overriden by environmental 
 # values, but should include all endpoints
 # required by this chart
@@ -34,3 +40,4 @@ endpoints:
     port:
         admin: 35356
         public: 5000
+