111 Commits

Author SHA1 Message Date
Andrii Ostapenko
42712e1d36
Pass ovs agent config to dhcp agent
Since metadata server is accessed via dhcp namespace, dhcp relies on
conf.OVS.datapath_type for [0] logic to disable checksum offloading
that is not supported with ovs-dpdk, making metadata server not available.

[0] https://opendev.org/openstack/neutron/src/branch/stable/train/neutron/agent/linux/interface.py#L444-L446

Change-Id: I382af9d9e83b39fd9a616351e7cd5a752a603e77
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>
2020-10-30 15:21:34 -05:00
Tin Lam
6895a5ba7a fix(neutron): fixes tls issue
Updated neutron to use an Nginx sidecar to terminate internal TLS rather
than using Apache with a separate RPC servers. Multiple RPC servers (in
sidecar) causes communication issues with RabbitMQ causing expected
errors.

Change-Id: Iaa6d3d64b730a54b1b85a338517bcb5be1842bda
Signed-off-by: Tin Lam <tin@irrational.io>
2020-10-21 11:02:57 -05:00
Zuul
0abcd93fd9 Merge "Do not pass extra config files to neutron agents" 2020-09-14 22:06:07 +00:00
rajesh.kudaka
a2f2e0418f Update ovs dpdk config when required
This commit enables user to update dpdk bond config
only when required using the flag UPDATE_DPDK_BOND_CONFIG.
This helps in avoiding disruption in ovs dpdk during ovs
agent restart or when there is a update in bond config.

Setting UPDATE_DPDK_BOND_CONFIG to true will have default
behavior.

Setting UPDATE_DPDK_BOND_CONFIG to false will disable
configuration of bonds after the first run and can be
set to true when required.

Change-Id: I4c8ec145c8f1c1c1b5f7a5201f792e040fdd89a2
2020-08-14 11:26:53 -05:00
Zuul
b0de771314 Merge "Remove delete port commands in ovs agent init" 2020-08-11 20:23:31 +00:00
rajesh.kudaka
d2deb2b2dc Remove delete port commands in ovs agent init
This commit removes 'del-port' commands in neutron ovs
agent init script. Since, 'add-bond' command allows
modification of the existing options, the commands
being removed are not required. This also allows to
avoid disruptions in ovs caused by deleting ports on
restart.

Change-Id: I7201b87da7b20e1ca8efedf5d86a23123ccfa150
2020-08-11 08:26:44 +00:00
Ann Taraday
75472fc856 Do not pass extra config files to neutron agents
Passing config files from other agents result in
incorrent loading of extensions.

Value metadata_proxy_socket should be set in neutron.conf

Change-Id: If22168ccc77c918f7cfcb5d9d0d548f02d2a09e9
2020-08-07 22:08:55 +00:00
Tin Lam
7956310ead fix(horizon and neutron): adds tls to test pod
This patch set puts in the missing certificates to the test-pod.
It also corrects the path of sriov_agent.ini file

Change-Id: Ice2124f92a36d545726243fff60db25fbb2ea9c0
2020-08-04 20:56:26 +00:00
Zuul
fa91a256e1 Merge "Revert "Remove ctl socket ownership"" 2020-08-03 20:53:39 +00:00
Gupta, Sangeet (sg774j)
b7667a5507 neutron: pass rps server .ini for enabled plugins
This patch set passes .ini config file to the rpc-server
for the enabled plugins.

Change-Id: I3d84fd67367c68d38541c6f8b5a38ab8a906d454
2020-08-03 15:07:13 +00:00
Kudaka Poorna Rajesh
c3fe19f259 Revert "Remove ctl socket ownership"
OVS_CTL file is required by other parts of the init
script.

This reverts commit a9693843d77525decefc8a0ba0528624f9e11350.

Change-Id: Ia11dc18e0b13d5fe01918a4c7febb82b19303527
2020-08-03 15:05:38 +00:00
Tin Lam
918a307427 feat(tls): add tls support to openstack services
This patch set enables TLS for the following OpenStack services: keystone,
horizon, glance, cinder, heat, nova, placement and neutron for s- (stein)
and t- (train) release. This serves as a consolidation and clean up patch
for the following patches:

[0] https://review.opendev.org/#/c/733291
[1] https://review.opendev.org/#/c/735202
[2] https://review.opendev.org/#/c/733962
[3] https://review.opendev.org/#/c/733404
[4] https://review.opendev.org/#/c/734896

This also addresses comments mentioned in previous patches.

Co-authored-by: Gage Hugo <gagehugo@gmail.com>
Co-authored-by: sgupta <sg774j@att.com>

Depends-on: https://review.opendev.org/#/c/737194/

Change-Id: Id34ace54298660b4b151522916e929a29f5731be
Signed-off-by: Tin Lam <tin@irrational.io>
2020-07-10 09:36:31 -05:00
Zuul
135e2c8b64 Merge "Add TungstenFabric compatibility to charts" 2020-07-08 13:47:49 +00:00
OlegBravo
4f2eb8cac6 Add TungstenFabric compatibility to charts
The charts changes are required for deployment
of various clouds based on Tungsten Fabric SDN.
Right now it's tested for Airship-in-a-bottle.

The code cannot be tested currently in
OpenStack Helm project because of absence of
tests and platform for that.

This patchset doesn't have Heat-related changes,
they'll be added later.

Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0
Depends-On: https://review.opendev.org/#/c/734635/
2020-06-26 10:39:20 +03:00
rajesh.kudaka
a9693843d7 Remove ctl socket ownership
Depends-On: https://review.opendev.org/#/c/722318/

Change-Id: I6743529c7cfbb5b828108f7c27e7f1c10f8d46c8
2020-06-26 05:40:18 +00:00
Zuul
35a794ccc8 Merge "[neutron] Unhardcode probes timings" 2020-06-03 07:36:05 +00:00
Roy Tang
da47437f32 Allow neutron sriov agent to set num_queues per vf
Change-Id: I465c882ab2939e5c0297c889fddc6c93bf5a7b91
2020-05-28 21:36:24 +00:00
John Haan
63556c3de3 bugfix for systax error
neutron-ironic-agent script has syntax error.
This patch is for resolving the error.

Change-Id: I4a4e0bbab5ce1f9ce45c0723b92a2af647212592
2020-05-21 06:20:55 +00:00
Roy Tang
8b59f26ae4 Minor fix to neutron sriov agent init script
Change-Id: I618b2974923b298bdd66c79398868f06c963f393
2020-05-05 07:51:54 -07:00
Roy Tang
03a43cb91e Add support to set ovs module log level
Change-Id: I1fcd5b49cb2af4c76ed32b332f83ca8fa783a3c6
2020-04-17 11:02:19 -07:00
Gage Hugo
db79e79788 Remove OSH Authors copyright
The current copyright refers to a non-existent group
"openstack helm authors" with often out-of-date references that
are confusing when adding a new file to the repo.

This change removes all references to this copyright by the
non-existent group and any blank lines underneath.

Change-Id: Ia035037e000f1bf95202fc07b8cd1ad0fc019094
2020-04-03 20:53:32 +00:00
Oleksii Grudev
6969a5d596 [neutron] Unhardcode probes timings
This patch adds ability to unhardcode readiness/
liveness probes timings for those probes which still
were hardcoded. Moreover it introduces
RPC_PROBE_TIMEOUT and RPC_PROBE_RETRIES variables
which are passed to health probe script and
allow to unhardcode RPCtest  timeout and number of
retries

Change-Id: I2e48eed26abb82208a4ac4ae596d27ca8db99c90
2020-04-01 14:57:11 +03:00
Roy Tang
6142f32c02 Update neutron ovs-agent init
There is a bug with the Intel i40e driver version 2.11.21 or earlier
where the interface VF spoof check must be toggle on and off after bond
is created (TODO: insert release note or bug here)

Change-Id: I9723e52fc87291f5e90df29a154c04180cbfe955
2020-03-18 18:37:15 +00:00
Zuul
5763f146c9 Merge "Revert "Add neutron-ovs-cleanup to neutron charts"" 2020-03-10 00:52:42 +00:00
Hemachandra Reddy
9abf057340 Revert "Add neutron-ovs-cleanup to neutron charts"
This reverts commit 09d6a3e68c3d95e27ce7a7395735d058062e9d17.

It causes failures during brown field upgrade.

Change-Id: Ie619358bd0ae046bfb94b9e9d811251b54d2897e
2020-03-09 17:49:17 +00:00
Deepak Tiwari
a101959321 OVS-DPDK: support for VLAN underlay for tunnel traffic
For OVS-DPDK deployments, where tunnel interface is bound to DPDK, there
should be support to transport the tunnel traffic over a VLAN network.

Change-Id: I1e63c9a6eb03a3f78a8592244d7c4b4928164fa5
2020-02-26 08:42:38 +00:00
Zuul
8c6269f719 Merge "Fix health-probe concurrency and timings" 2020-02-20 22:04:40 +00:00
Zuul
7d34ef85e9 Merge "Add network namespace cleanup" 2020-02-20 19:02:55 +00:00
Sangeet Gupta
414b10fab0 Fix health-probe concurrency and timings
Changed Nova and Neutron health-probe script to exit if previous
probe process is still running.
The health-probe has RPC call timeout of 60 seconds and has 2
retries. In worst case scenario the probe process can run a little
over 180 seconds. Changing the periodSeconds so that probe starts
after previous one is complete. Also changing timeoutSeconds value
a little to give little more extra time for the probe to finish.
Increasing the liveness probe periods as they are not do critical
which will reduce the resource usage for the probes.

Co-authored-by: Randeep Jalli <rj2083@att.com>

Change-Id: Ife1c381d663c1e271a5099bdc6d0dfefb00d8d73
2020-02-18 17:24:23 +00:00
Deepak Tiwari
09d6a3e68c Add neutron-ovs-cleanup to neutron charts
neutron-ovs-cleanup needs to be run at the startup once

Change-Id: I0160bb0377082026af4aa90413196ce65cfd23c9
2020-02-18 05:11:24 +00:00
Hemachandra Reddy
62db99d1d1 Add network namespace cleanup
Removes stale DHCP and L3 namespaces. The cron runs once in 12 hours.

Network namespace cleanup is implemented as a daemonset as Kubernetes
does not have a cronjob that works like daemonset-cronjob.
Network namespace cleanup should run on all nodes where DHCP and L3
agents run.

Change-Id: I7525e493067669026e0d57889a3e3238a2bd1308
2020-02-11 05:01:36 +00:00
Hemachandra Reddy
f00777e57d Make sure requested mtu is set
The 'options' keyword for setting mtu in 'set interface' does not
set mtu and it seems to ignore/fail the request silently.

Change-Id: Icec98c5166611a8c538f93e6326cf7d20b545ecd
2020-01-28 18:28:25 +00:00
Roy Tang
fdce0e46d9 Add QOS support for neutron sriov
Change-Id: I5a1df5d7f6cf179e8cd26a288b5749340b8827dd
2020-01-27 14:36:49 +00:00
Tin Lam
def68865a2 Add functionality to specify FQDN
Patch set to allow for FQDN for neutron agents.

Change-Id: Idde7ba35e940de59e0def35507ce2506cad672ed
Signed-off-by: Tin Lam <tin@irrational.io>
2020-01-09 16:10:37 -06:00
Roy Tang
97ac0575ba Update neutron ovs agent for ovs-dpdk
This ps update neutron ovs agent to support properly:
- setting mtu on dpdk bond and nic interface port
- setting vhost-iommu-support on dpdk bond and nic interface port
- setting n_txq values on dpdk bond and nic interface port

Change-Id: I422fa21a622642ecb7c49914fef04073e4f984bc
2019-12-13 10:37:10 -06:00
Zuul
3784a3fe2f Merge "Fix readiness probe of neutron-ovs-agent for OVS<2.10.0" 2019-10-29 16:06:46 +00:00
Sphicas, Phil (ps3910)
e83f50633d neutron-ovs-agent-init: remove neutron-sanity-check
This change removes neutron-sanity-check from neutron-ovs-agent-init.
Proper dependencies now exist, as outlined in the original issue [0],
and the check is no longer required.

[0] https://github.com/att-comdev/openstack-helm/issues/88#issuecomment-270829530]

Depends-On: https://review.opendev.org/691035/
Change-Id: I6f8849ea519da76ac5289e86dbc7beb57cc9baba
Related-Bug: #1842517
2019-10-24 14:49:09 -07:00
Georg Kunz
dddbf37c0e Fix readiness probe of neutron-ovs-agent for OVS<2.10.0
A recently introduced readiness probe for neutron-ovs-agent makes use of
an OVSDB table entry 'dpdk_initialized' which does not exist in OVS
versions preceeding v2.10.0. This patch changes the readiness probe to
exit successfully if this table entry does not exit. Thereby it does not
give any guarantees for older versions of OVS, but at least allows the
readiness probe to pass.

Change-Id: Ic77c6bdd60730c1a7c5e55fdb4afc6db938f0ddb
2019-10-21 16:16:21 +02:00
Zuul
083ae1d515 Merge "Remove need to configure VF during DPDK deployment" 2019-10-16 12:48:04 +00:00
Tin Lam
938a1deb03 Ensure python scripts are py3 compatible
This patch set is one of many to migrate existing code/script to be
python-3 compatible as python-2 is sunsetting in January of 2020.

Change-Id: I337069203a3273e9aba6a37294ee3c25e5b4870a
Signed-off-by: Tin Lam <tin@irrational.io>
2019-10-10 23:10:03 +00:00
Zuul
34aed6f20c Merge "Fix psutil inconsistencies" 2019-10-10 14:51:52 +00:00
Rihab Banday
05bff26162 Remove need to configure VF during DPDK deployment
The current configuration expects VF & bonding info by default. This patch
set removes the need to configure them for every deployment.

Change-Id: Id546c113b2d3c42591a0326ee8cd442cccc73578
2019-10-09 11:39:27 +02:00
Zuul
76a14a0cc6 Merge "Add readiness checks to ovs agent" 2019-10-08 14:50:46 +00:00
Hemachandra Reddy
3ba23f7ab0 Fix psutil inconsistencies
Python psutil library has not been consistent in behavior
a. gives trucated process names at times
b. the truncated names sometimes contain path to Python instead
of the program name Python runs

Change-Id: I99b77a4c28761a2187e59be4e562d5893ef3caa9
2019-10-07 21:43:15 +00:00
Zuul
f2360f485d Merge "Remove explicit call to py2" 2019-09-27 10:48:32 +00:00
Pete Birley
adfc3fb772 Neutron: Ensure test project purge targets correct project
This PS updates the test project purge script to target specificly
the desired project by its id.

Change-Id: I54bfaa7727fdad781bdecc31251c1fe53f912c18
Signed-off-by: Pete Birley <pete@port.direct>
2019-09-26 13:30:33 -05:00
Pete Birley
b1f8446e5b Neutron: Update force purge of test project to be less aggressive
This PS updates the os purge of the test project to be an optional
operator driven choice, as they will also need to ensure
the project is unique to neutron testing.

Additionally this updates the purge image to be driven by the
charts values.yaml, as with every other image in OSH.

Change-Id: I46807f7c4922a1b411386641eddbd8957ab56f05
Signed-off-by: Pete Birley <pete@port.direct>
2019-09-26 13:05:30 -05:00
Zuul
b4d673a90e Merge "[neutron] Support baremetal mechanism driver" 2019-09-26 14:22:10 +00:00
rajesh.kudaka
fa92e365f5 Add readiness checks to ovs agent
This commit adds readiness checks to neutron ovs agent
to check if the ovs and dpdk configurations are working
without errors.

Change-Id: I48277bdbd91ec8121e5fec300aeb646a80a65d29
2019-09-25 04:51:16 -05:00
ad620p
f830186c45 Support for Neutron Helm test cleanup and reset for abnormal failures
Rally usually cleans up all its resources in normal executions - normal
test success cases and normal test failure cases. But the generic cleanup
does not work well for out of the system failures like process
interruptions, pod failures, disaster cleanup etc.
This is a known issue in rally-openstack. -
"Current generic mechanism is nice but it doesn't work enough well in real life.
And in cases of existing users, persistence context
and disaster cleanups it doesn't work well."

Hence, if we shall face above such issues, it is becoming impossible
to run "helm test neutron" again because of the stale data
and different quota limits mentioned in the values.yaml.
Hence we need to purge the stale data from the "test"
project as well as reset the quota limit for such scenarios.

For the normal executions, this patch has to do nothing,
but for unexpected failures, this patch will purge the stale data
from test project and reset the quota as defined in
values.yaml for the next run.

Change-Id: I3f6851582e2ac1aa1d375fcd13c07f4f57f45dc8
2019-09-25 09:50:52 +00:00