308 Commits

Author SHA1 Message Date
Mohammed Naser
89bf3cf7b8 neutron: migrate IP for bridges
This patch makes a change to the Helm chart so that it migrates the
IP addresse assigned to an interface to `br-ex`.  It's assumed that
if the operator put an IP address on that interface, they likely
need it, and if they just had no IP address then it's there for L2
connectivity so nothing won't happen anyways.

Change-Id: I17dc2e532dc8b472a5c5c16ff2ec2bdcfb5bfac5
2022-04-08 11:46:51 -03:00
Thiago Brito
c6c58102d3 Enable taint toleration for neutron
This changes use the helm-toolkit template for toleration
in openstack services

Signed-off-by: Lucas Cavalcante <lucasmedeiros.cavalcante@windriver.com>
Story: 2009276
Task: 43531
Depends-On: I168837f962465d1c89acc511b7bf4064ac4b546c
Change-Id: Ib33118af841b3273f146d94c6499c232b793a0be
2022-03-22 18:44:40 +00:00
Thiago Brito
151c03d5ec Fix infinite recursion deadlock on netns cleanup
When, for some reason, the neutron netns agent is misconfigured and is
producing errors, this infinite recursion is generating a deadlock on
cpu usage since it repeats with no interval. This fix adds some shorter
sleeps to work around it.

Signed-off-by: Thiago Brito <thiago.brito@windriver.com>
Change-Id: Icf840ea965d0652d6118a1b840168df95ba95fac
2022-03-10 15:02:11 -03:00
Anderson, Craig (ca846m)
d514395d81 Improve health probe logging for nova and neutron
1. Log specific compute services failing rabbitMQ socket tests in nova
   health probe
2. Log specific compute services failing Database socket tests in nova
   health probe
3. Make log level configurable for nova and neutron health probes

Change-Id: I5e5d909d598af734596eb1732ae42808c1f6cd12
2022-02-22 10:05:15 +00:00
Thiago Brito
21157f8e6a Add option to disable helm.sh/hook annotations
Adding a helm3_hook in values.yaml file in case hooks needs
to be disabled (e.g. on Helm v2).

Signed-off-by: Thiago Brito <thiago.brito@windriver.com>
Change-Id: I1c03ea9ee88d1306283ce577b100c9864bec5d1b
2021-09-29 18:40:15 -03:00
xuxant02@gmail.com
ee0c142748 Made dnsmasq.conf overridable in configmap-etc secret
As dnsmasq.conf data in configmap-etc secret was empty, there was no option
to override it. Added the section in the values.yaml file where the dnsmasq.conf
config can be added which will be reflected in dhcp-agent.

Change-Id: If11c33f6f837dbf0d16e54cc92cabf399e773968
2021-07-14 14:24:05 +05:45
MirgDenis
27e12b88ad Fix neutron-openvswitch-agent-init script
Using local variables outside of function is not allowed
in bash. During adding route it tries to delete cached
route and fails with "Not found" because it can delete only
user created routes, so we need to omit Cached routes
in ovs/route/show listing.

Change-Id: Ifc8da7fc36206f7ebd2e6198dbf192a5a40261af
2021-07-13 14:48:40 +03:00
Gupta, Sangeet (sg774j)
5028aa8de1 Mount rabbitmq TLS secret
Mount rabbitmq TLS secret to openstack services which support internal
TLS. Once internal TLS support is added to other service, the TLSed 
rabbitmq support should be added.

Depends-on: https://review.opendev.org/c/openstack/openstack-helm-infra/+/795188

Change-Id: I9aa272e365f846746f2e06aa7b7010db730e17df
2021-06-10 14:12:57 +00:00
Thiago Brito
8ab6013409 Changing all policies to yaml format
In the Victoria cycle oslo.policy decided to change all default policies
to yaml format. Today on openstack-helm we have a mix of json and yaml
on projects and, after having a bad time debugging policies that should
have beeing mounted somewhere but was being mounted elsewhere, I'm
proposing this change so we can unify the delivery method for all
policies across components on yaml (that is supported for quite some
time). This will also avoid having problems in the future as the
services move from json to yaml.

[1] https://specs.openstack.org/openstack/oslo-specs/specs/victoria/policy-json-to-yaml.html

Signed-off-by: Thiago Brito <thiago.brito@windriver.com>
Change-Id: Id170bf184e44fd77cd53929d474582022a5b6d4f
2021-05-26 18:15:41 -03:00
Haider, Nafiz (nh532m)
c900712f30 feat(tls): Make openstack services compatible with rabbitmq TLS
Depends-on: https://review.opendev.org/c/openstack/openstack-helm-infra/+/770678

Co-authored-by: Sangeet Gupta <sg774j@att.com>

Change-Id: I11e9ad3f4079b0e12e498f9ed57e5b87ae9dc66a
2021-05-21 01:27:18 +00:00
Susanta Gautam
b4e2a85b49 Add helm.sh/hook related annotation for neutron
Chart upgrading was failing due to some immutable fields in job are needed to upgrade. So, we thought using the post-install and post-upgrade
helm hook for job to force the job resource to execute after all resources are created. And as some jobs are dependent on each other i.e.
some jobs needs to run in order for helm hook to be successful. For that we used hook-weight to control resource creation order.

Change-Id: I26881324d101a986b7367d4682e9adcd07a24b13
2021-03-18 08:49:09 +05:45
Roy Tang
e491b838fa Update ovs agent to support host/label overrides
In the ovs agent code, some of the secret ref are hardcoded, and
it breaks the host/label overrides mechanism.  This patchset
fixes it.

Change-Id: Icf3ffc86fde77b1948e86cfd62e83fbdfe16ad8e
2021-02-16 15:49:05 -06:00
Sphicas, Phil (ps3910)
c7c19e85c0 Use HostToContainer mountPropagation
For any host mounts that include /var/lib/kubelet, use HostToContainer
mountPropagation, which avoids creating extra references to mounts in
other containers.

Affects the following resources:
* neutron-lb-agent daemonset
* neutron-ovs-agent daemonset
* neutron-sriov-agent daemonset (unused mount removed)
* nova-compute daemeonset

Change-Id: I92f1700e56517a74b1fbcc8e3a68567045a593ee
2021-01-07 20:27:08 +00:00
KHIYANI, RAHUL (rk0850)
e1fac0ba4d Add missing flags to nginx container in neutron chart
This adds readOnly-fs flag to nginx container

Change-Id: Ie75e460fe2f45f1ae908f1fe475461267251461f
2020-11-04 00:04:09 -06:00
Andrii Ostapenko
42712e1d36
Pass ovs agent config to dhcp agent
Since metadata server is accessed via dhcp namespace, dhcp relies on
conf.OVS.datapath_type for [0] logic to disable checksum offloading
that is not supported with ovs-dpdk, making metadata server not available.

[0] https://opendev.org/openstack/neutron/src/branch/stable/train/neutron/agent/linux/interface.py#L444-L446

Change-Id: I382af9d9e83b39fd9a616351e7cd5a752a603e77
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>
2020-10-30 15:21:34 -05:00
KHIYANI, RAHUL (rk0850)
32c72a08ea Update neutron to use Nginx apparmor profile
neutron-rpc-server container was removed and nginx container
was added here in this commit https://review.opendev.org/#/c/758919/4

Change-Id: Ie7b3a23ea8d7a5d3b1788bce1c1419fe1f627b75
2020-10-23 10:18:10 -05:00
Tin Lam
6895a5ba7a fix(neutron): fixes tls issue
Updated neutron to use an Nginx sidecar to terminate internal TLS rather
than using Apache with a separate RPC servers. Multiple RPC servers (in
sidecar) causes communication issues with RabbitMQ causing expected
errors.

Change-Id: Iaa6d3d64b730a54b1b85a338517bcb5be1842bda
Signed-off-by: Tin Lam <tin@irrational.io>
2020-10-21 11:02:57 -05:00
Zuul
0abcd93fd9 Merge "Do not pass extra config files to neutron agents" 2020-09-14 22:06:07 +00:00
Mohammed Naser
0ff2beee30 neutron: fix default value for tungsten fabric
The lack of quotes means if it defaults to nothing, Kubernetes is not
happy because it is trying to set a nil value instead of an empty
string.

Change-Id: I7af08b93a4df92acd9d428266aaa7922a66cf599
2020-09-11 18:48:03 -04:00
PrateekDodda
c57391366a Implement missing security context template for deployment server
This change adds security context template at pod/container level

Change-Id: I2180cdf934ce21bc5ae7148f2830d1a8683e82db
2020-09-03 14:22:22 +00:00
diwakar thyagaraj
9c39f2e328 Add Apparmor for Missing containers for glance and neutron pods
1)Fixed nginx container in glance.
2)Fixed rpc server in neutron.
3)Enabled Certificates for creating pods.

Change-Id: Ida510ee22808b818e256f93b11d2e1ed36f63a19
Signed-off-by: diwakar thyagaraj <diwakar.chitoor.thyagaraj@att.com>
2020-08-27 21:27:36 +00:00
rajesh.kudaka
a2f2e0418f Update ovs dpdk config when required
This commit enables user to update dpdk bond config
only when required using the flag UPDATE_DPDK_BOND_CONFIG.
This helps in avoiding disruption in ovs dpdk during ovs
agent restart or when there is a update in bond config.

Setting UPDATE_DPDK_BOND_CONFIG to true will have default
behavior.

Setting UPDATE_DPDK_BOND_CONFIG to false will disable
configuration of bonds after the first run and can be
set to true when required.

Change-Id: I4c8ec145c8f1c1c1b5f7a5201f792e040fdd89a2
2020-08-14 11:26:53 -05:00
Zuul
b0de771314 Merge "Remove delete port commands in ovs agent init" 2020-08-11 20:23:31 +00:00
rajesh.kudaka
d2deb2b2dc Remove delete port commands in ovs agent init
This commit removes 'del-port' commands in neutron ovs
agent init script. Since, 'add-bond' command allows
modification of the existing options, the commands
being removed are not required. This also allows to
avoid disruptions in ovs caused by deleting ports on
restart.

Change-Id: I7201b87da7b20e1ca8efedf5d86a23123ccfa150
2020-08-11 08:26:44 +00:00
Ann Taraday
75472fc856 Do not pass extra config files to neutron agents
Passing config files from other agents result in
incorrent loading of extensions.

Value metadata_proxy_socket should be set in neutron.conf

Change-Id: If22168ccc77c918f7cfcb5d9d0d548f02d2a09e9
2020-08-07 22:08:55 +00:00
Tin Lam
7956310ead fix(horizon and neutron): adds tls to test pod
This patch set puts in the missing certificates to the test-pod.
It also corrects the path of sriov_agent.ini file

Change-Id: Ice2124f92a36d545726243fff60db25fbb2ea9c0
2020-08-04 20:56:26 +00:00
Zuul
fa91a256e1 Merge "Revert "Remove ctl socket ownership"" 2020-08-03 20:53:39 +00:00
Gupta, Sangeet (sg774j)
b7667a5507 neutron: pass rps server .ini for enabled plugins
This patch set passes .ini config file to the rpc-server
for the enabled plugins.

Change-Id: I3d84fd67367c68d38541c6f8b5a38ab8a906d454
2020-08-03 15:07:13 +00:00
Kudaka Poorna Rajesh
c3fe19f259 Revert "Remove ctl socket ownership"
OVS_CTL file is required by other parts of the init
script.

This reverts commit a9693843d77525decefc8a0ba0528624f9e11350.

Change-Id: Ia11dc18e0b13d5fe01918a4c7febb82b19303527
2020-08-03 15:05:38 +00:00
Gupta, Sangeet (sg774j)
7b720184e3 feat(tls): Make openstack services compatible with mariadb with TLS
Change database scerets.

Change-Id: I068dfcb23d596d4b9bcde1944fb4def010490452
2020-07-24 23:02:09 +00:00
sgupta
702c17eb78 feat(tls): Make openstack services compatible with mariadb with TLS
Depends-on: https://review.opendev.org/#/c/741037/
Change-Id: I21f4ede3bd18c0af8da1eba60cd0b7b932a31410
2020-07-14 23:32:03 +00:00
Zuul
009bde9d31 Merge "Add missing security context to Neutron pods/containers" 2020-07-13 18:46:33 +00:00
Andrii Ostapenko
44d263b2bf Enable templates linting
- braces
- brackets
- colons
- commas
- comments
- hyphens
- indentation
- key-duplicates

with corresponding code changes.

Also disable enforcement for document-(start|end) rules and
disables warnings to increase readability.

* Unrestrict octal values rule since benefits of file modes readability
  exceed possible issues with yaml 1.2 adoption in future k8s versions.
  These issues will be addressed when/if they occur.

Change-Id: Ic5e327cf40c4b09c90738baff56419a6cef132da
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>
2020-07-11 00:52:51 +00:00
Tin Lam
918a307427 feat(tls): add tls support to openstack services
This patch set enables TLS for the following OpenStack services: keystone,
horizon, glance, cinder, heat, nova, placement and neutron for s- (stein)
and t- (train) release. This serves as a consolidation and clean up patch
for the following patches:

[0] https://review.opendev.org/#/c/733291
[1] https://review.opendev.org/#/c/735202
[2] https://review.opendev.org/#/c/733962
[3] https://review.opendev.org/#/c/733404
[4] https://review.opendev.org/#/c/734896

This also addresses comments mentioned in previous patches.

Co-authored-by: Gage Hugo <gagehugo@gmail.com>
Co-authored-by: sgupta <sg774j@att.com>

Depends-on: https://review.opendev.org/#/c/737194/

Change-Id: Id34ace54298660b4b151522916e929a29f5731be
Signed-off-by: Tin Lam <tin@irrational.io>
2020-07-10 09:36:31 -05:00
Zuul
135e2c8b64 Merge "Add TungstenFabric compatibility to charts" 2020-07-08 13:47:49 +00:00
DODDA, PRATEEK REDDY (PD2839)
f742ebd6ae Add missing security context to Neutron pods/containers
This updates the Neutron chart to include the pod
security context on the pod template.

This also adds the container security context to set
readOnlyRootFilesystem flag to true

Change-Id: I50ccec785eb3b18d6c00df2ad5f566a72db4604d
2020-07-07 01:41:22 +00:00
OlegBravo
4f2eb8cac6 Add TungstenFabric compatibility to charts
The charts changes are required for deployment
of various clouds based on Tungsten Fabric SDN.
Right now it's tested for Airship-in-a-bottle.

The code cannot be tested currently in
OpenStack Helm project because of absence of
tests and platform for that.

This patchset doesn't have Heat-related changes,
they'll be added later.

Change-Id: I73f2ced2b09dbb93146334b59fe4571fa13dbfb0
Depends-On: https://review.opendev.org/#/c/734635/
2020-06-26 10:39:20 +03:00
rajesh.kudaka
a9693843d7 Remove ctl socket ownership
Depends-On: https://review.opendev.org/#/c/722318/

Change-Id: I6743529c7cfbb5b828108f7c27e7f1c10f8d46c8
2020-06-26 05:40:18 +00:00
Zuul
35a794ccc8 Merge "[neutron] Unhardcode probes timings" 2020-06-03 07:36:05 +00:00
Zuul
08e652a06f Merge "Allow neutron sriov agent to set num_queues per vf" 2020-06-02 15:18:25 +00:00
diwakar thyagaraj
477602f2e7 Enable Apparmor to osh test Pods
Change-Id: I0a67f66cc4ed8a1e3a5c3c458b7c1521f9169160
Signed-off-by: diwakar thyagaraj <diwakar.chitoor.thyagaraj@att.com>
2020-06-01 18:32:51 +00:00
Roy Tang
da47437f32 Allow neutron sriov agent to set num_queues per vf
Change-Id: I465c882ab2939e5c0297c889fddc6c93bf5a7b91
2020-05-28 21:36:24 +00:00
John Haan
63556c3de3 bugfix for systax error
neutron-ironic-agent script has syntax error.
This patch is for resolving the error.

Change-Id: I4a4e0bbab5ce1f9ce45c0723b92a2af647212592
2020-05-21 06:20:55 +00:00
Zuul
87e9387b38 Merge "Enable Apparmor to init container for neutron" 2020-05-07 18:31:39 +00:00
diwakar thyagaraj
3d4b2630c1 Enable Apparmor to init container for neutron
Change-Id: I5df5f5ba36209d48a5a70975823ae73e1ca5c028
Signed-off-by: diwakar thyagaraj <diwakar.chitoor.thyagaraj@att.com>
2020-05-06 22:51:22 +00:00
Roy Tang
8b59f26ae4 Minor fix to neutron sriov agent init script
Change-Id: I618b2974923b298bdd66c79398868f06c963f393
2020-05-05 07:51:54 -07:00
Roy Tang
03a43cb91e Add support to set ovs module log level
Change-Id: I1fcd5b49cb2af4c76ed32b332f83ca8fa783a3c6
2020-04-17 11:02:19 -07:00
Gage Hugo
db79e79788 Remove OSH Authors copyright
The current copyright refers to a non-existent group
"openstack helm authors" with often out-of-date references that
are confusing when adding a new file to the repo.

This change removes all references to this copyright by the
non-existent group and any blank lines underneath.

Change-Id: Ia035037e000f1bf95202fc07b8cd1ad0fc019094
2020-04-03 20:53:32 +00:00
Oleksii Grudev
6969a5d596 [neutron] Unhardcode probes timings
This patch adds ability to unhardcode readiness/
liveness probes timings for those probes which still
were hardcoded. Moreover it introduces
RPC_PROBE_TIMEOUT and RPC_PROBE_RETRIES variables
which are passed to health probe script and
allow to unhardcode RPCtest  timeout and number of
retries

Change-Id: I2e48eed26abb82208a4ac4ae596d27ca8db99c90
2020-04-01 14:57:11 +03:00
Roy Tang
6142f32c02 Update neutron ovs-agent init
There is a bug with the Intel i40e driver version 2.11.21 or earlier
where the interface VF spoof check must be toggle on and off after bond
is created (TODO: insert release note or bug here)

Change-Id: I9723e52fc87291f5e90df29a154c04180cbfe955
2020-03-18 18:37:15 +00:00