Remove legacy-npm-upload job

We now have an existing native job and all usage is removed, we can
remove the legacy job.

Change-Id: I696a23792f8e4056b788ad4a8b018c423aa1af68
Depends-On: I5cccd00518afcc50c575a4bb1937345a30fe584f

playbooks/legacy/npm-upload/run.yaml

@@ -1,14 +0,0 @@
-- hosts: all
-  name: Autoconverted job legacy-npm-upload from old job {name}-npm-upload
-  tasks:
-
-    - name: Ensure legacy workspace directory
-      file:
-        path: '{{ ansible_user_dir }}/workspace'
-        state: directory
-
-    - shell:
-        cmd: |
-          /usr/local/jenkins/slave_scripts/npm-tarball-upload.sh $ZUUL_SHORT_PROJECT_NAME tarballs.openstack.org
-        chdir: '{{ ansible_user_dir }}/workspace'
-      environment: '{{ zuul | zuul_legacy_vars }}'

zuul.d/zuul-legacy-jobs.yaml

@@ -2397,14 +2397,6 @@
       - openstack/nova
       - openstack/python-novaclient
 
-- job:
-    name: legacy-npm-upload
-    parent: legacy-base
-    run: playbooks/legacy/npm-upload/run.yaml
-    timeout: 1800
-    dependencies:
-      - publish-openstack-python-tarball
-
 - job:
     name: legacy-omni-tests
     parent: legacy-base