From b56b184d1820b56b3b578e0602684d68bd525806 Mon Sep 17 00:00:00 2001 From: Mohammed Naser Date: Thu, 12 Oct 2017 17:43:48 -0400 Subject: [PATCH] Move tox_envlist into job variables for releasenote jobs At the moment, the tox_envlist is defined inside the include_role for tox as releasenotes. This means that other roles which run beforehand such as tox-siblings will use the default value of venv instead which isn't always defined. This patch makes the change to make that variable defined in the job which means that all other roles will reference the correct tox envlist in the entire job run. Change-Id: I0323f8f1bccf720268d947b8e1dcb6c5f8b26dfa --- roles/build-releasenotes/tasks/main.yaml | 2 -- zuul.d/jobs.yaml | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/build-releasenotes/tasks/main.yaml b/roles/build-releasenotes/tasks/main.yaml index f9c9305f..e020a393 100644 --- a/roles/build-releasenotes/tasks/main.yaml +++ b/roles/build-releasenotes/tasks/main.yaml @@ -117,5 +117,3 @@ - name: Build release notes include_role: name: tox - vars: - tox_envlist: releasenotes diff --git a/zuul.d/jobs.yaml b/zuul.d/jobs.yaml index 650a62a6..9219a433 100644 --- a/zuul.d/jobs.yaml +++ b/zuul.d/jobs.yaml @@ -404,6 +404,8 @@ - ^releasenotes/.* - ^tox.ini - ^.*requirements.txt$ + vars: + tox_envlist: releasenotes - job: name: legacy-base