openstack/sunbeam-charms
Code Issues Proposed changes

Check relation exists in ovsdb lib

Browse Source
This commit is contained in:
Liam Young 2022-02-14 11:10:00 +00:00
parent b7e26988ff
commit 45cf162c8a
1 changed files with 4 additions and 3 deletions

7
charms/ovn-central-k8s/lib/charms/sunbeam_ovn_central_operator/v0/ovsdb.py

@ -37,7 +37,7 @@ LIBAPI = 0
# Increment this PATCH version before using `charmcraft publish-lib` or reset # Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version # to 0 if you are raising the major API version
LIBPATCH = 1 LIBPATCH = 2
# TODO: add your code here! Happy coding! # TODO: add your code here! Happy coding!
@ -122,8 +122,9 @@ class OVSDBCMSRequires(Object):
"""Retrieve value for key from all related units.""" """Retrieve value for key from all related units."""
values = [] values = []
relation = self.framework.model.get_relation(self.relation_name) relation = self.framework.model.get_relation(self.relation_name)
for unit in relation.units: if relation:
values.append(relation.data[unit].get(key)) for unit in relation.units:
values.append(relation.data[unit].get(key))
return values return values