openstack/sunbeam-charms
Code Issues Proposed changes

[ops-sunbeam] ingress_changed can fail when the relation is gone

Browse Source 
Catch AttributeError/KeyError as a stop gap to prevent _ingress_changed
to fail on relation-broken.

Change-Id: Ib29af68bf498c6adb84064f871dc678b783213c3
Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
This commit is contained in:
Guillaume Boutry 2024-08-21 09:10:48 +02:00
parent 8ca8d63e3a
commit 5210d9e230
No known key found for this signature in database
GPG Key ID: E95E3326872E55DE
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ops-sunbeam/ops_sunbeam/charm.py
View File

@ -851,9 +851,12 @@ class OSBaseOperatorAPICharm(OSBaseOperatorCharmK8S):
logger.debug("Received an ingress_changed event") logger.debug("Received an ingress_changed event")
if hasattr(self, "id_svc"): if hasattr(self, "id_svc"):
logger.debug( logger.debug(
"Updating service endpoints after ingress " "relation changed." "Updating service endpoints after ingress relation changed."
) )
try:
self.id_svc.update_service_endpoints(self.service_endpoints) self.id_svc.update_service_endpoints(self.service_endpoints)
except (AttributeError, KeyError):
pass
self.configure_charm(event) self.configure_charm(event)