From 1d01cd26531be3d315deebfc99132194686ef9e1 Mon Sep 17 00:00:00 2001 From: James Page Date: Wed, 26 Oct 2022 14:59:38 +0200 Subject: [PATCH] ovn: refresh address data on every instantiation Ensure that any IP address changes are noticed and provided on the ovsdb-cms relation - clients will need to update configuration and restart services as needed. Hostnames will not change. Change-Id: I969f58fd40ab7f7651ce0af03ebd70def25f2ca1 --- ops-sunbeam/ops_sunbeam/ovn/relation_handlers.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ops-sunbeam/ops_sunbeam/ovn/relation_handlers.py b/ops-sunbeam/ops_sunbeam/ovn/relation_handlers.py index a75ff69b..37465ac9 100644 --- a/ops-sunbeam/ops_sunbeam/ovn/relation_handlers.py +++ b/ops-sunbeam/ops_sunbeam/ovn/relation_handlers.py @@ -386,6 +386,7 @@ class OVSDBCMSProvidesHandler(sunbeam_rhandlers.RelationHandler, ) -> None: """Run constructor.""" super().__init__(charm, relation_name, callback_f, mandatory) + self._update_address_data() def setup_event_handler(self) -> ops.charm.Object: """Configure event handlers for an Identity service relation.""" @@ -404,14 +405,14 @@ class OVSDBCMSProvidesHandler(sunbeam_rhandlers.RelationHandler, def _on_ovsdb_service_ready(self, event: ops.framework.EventBase) -> None: """Handle OVSDB CMS change events.""" - # Ready is only emitted when the interface considers - # that the relation is complete (indicated by a password) - # _hostname = hostname or self.cluster_local_hostname + self.callback_f(event) + + def _update_address_data(self) -> None: + """Update hostname and IP address data on all relations.""" self.interface.set_unit_data({ 'bound-hostname': str(self.cluster_local_hostname), 'bound-address': str(self.cluster_local_addr), }) - self.callback_f(event) @property def ready(self) -> bool: