openstack/sunbeam-charms
Code Issues Proposed changes

Remove logging of the pebble plan

Browse Source 
The pebble plan output includes a full dump of the services config,
including environment variables.
These can contain sensitive information such as cloud credentials,
so avoid logging these.

An alternative method to retrieve this information for debugging,
is to ssh into the workload container, and run `pebble plan`:

```
~$ juju ssh --container tempest tempest/leader bash
/# pebble plan
services:
    periodic-test:
        summary: Running tempest periodically
...
```

Change-Id: If703418af6eb059e3c15fadcb6fce234b3801659
This commit is contained in:
Samuel Allan 2024-02-13 16:09:51 +10:30
parent c1d134943a
commit 6658845ebc
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ops-sunbeam/ops_sunbeam/container_handlers.py
View File

@ -91,7 +91,6 @@ class PebbleHandler(ops.framework.Object):
"""Handle pebble ready event."""
container = event.workload
container.add_layer(self.service_name, self.get_layer(), combine=True)
logger.debug(f"Plan: {container.get_plan()}")
self.charm.configure_charm(event)
def write_config(