From 9e723033b9c23cccb0ca536c8eb22df5e7dcaa2a Mon Sep 17 00:00:00 2001
From: Hemanth Nakkina <hemanth.nakkina@canonical.com>
Date: Wed, 21 Sep 2022 16:25:30 +0530
Subject: [PATCH] Add healthchecks to nova services

Add healthchecks to all the nova services

Change-Id: I5eb0aa23e9ff6dbc9da223d2aa0faeeefa852bde
---
 charms/nova-k8s/src/charm.py | 43 ++++++++++++++++++++++++++++++++----
 1 file changed, 39 insertions(+), 4 deletions(-)

diff --git a/charms/nova-k8s/src/charm.py b/charms/nova-k8s/src/charm.py
index 189a2d1e..4bebdd12 100755
--- a/charms/nova-k8s/src/charm.py
+++ b/charms/nova-k8s/src/charm.py
@@ -46,8 +46,8 @@ class WSGINovaMetadataConfigContext(sunbeam_ctxts.ConfigContext):
 
 class NovaSchedulerPebbleHandler(sunbeam_chandlers.ServicePebbleHandler):
 
-    def get_layer(self):
-        """Apache service
+    def get_layer(self) -> dict:
+        """Nova Scheduler service
 
         :returns: pebble layer configuration for scheduler service
         :rtype: dict
@@ -65,6 +65,24 @@ class NovaSchedulerPebbleHandler(sunbeam_chandlers.ServicePebbleHandler):
             }
         }
 
+    def get_healthcheck_layer(self) -> dict:
+        """Health check pebble layer.
+
+        :returns: pebble health check layer configuration for scheduler service
+        :rtype: dict
+        """
+        return {
+            "checks": {
+                "online": {
+                    "override": "replace",
+                    "level": "ready",
+                    "exec": {
+                        "command": "service nova-scheduler status"
+                    }
+                },
+            }
+        }
+
     def default_container_configs(self):
         return [
             sunbeam_core.ContainerConfigFile(
@@ -76,9 +94,9 @@ class NovaSchedulerPebbleHandler(sunbeam_chandlers.ServicePebbleHandler):
 class NovaConductorPebbleHandler(sunbeam_chandlers.ServicePebbleHandler):
 
     def get_layer(self):
-        """Apache service
+        """Nova Conductor service
 
-        :returns: pebble layer configuration for conductor service
+        :returns: pebble service layer configuration for conductor service
         :rtype: dict
         """
         return {
@@ -94,6 +112,23 @@ class NovaConductorPebbleHandler(sunbeam_chandlers.ServicePebbleHandler):
             }
         }
 
+    def get_healthcheck_layer(self) -> dict:
+        """Health check pebble layer.
+
+        :returns: pebble health check layer configuration for conductor service
+        """
+        return {
+            "checks": {
+                "online": {
+                    "override": "replace",
+                    "level": "ready",
+                    "exec": {
+                        "command": "service nova-conductor status"
+                    }
+                },
+            }
+        }
+
     def default_container_configs(self):
         return [
             sunbeam_core.ContainerConfigFile(