openstack/sunbeam-charms
Code Issues Proposed changes

Fix hardcoding of app name in tests

Browse Source 
Granting access to app is hardcoded for secrets
generated for identity service. Fix is to use
the app name instead of hardcoded value.

Change-Id: I71b63beac314ca6141c51ed3f0aaa53eefed75cb
This commit is contained in:
Hemanth Nakkina 2023-03-06 17:04:47 +05:30
parent 15bcfd0e15
commit 9f97514b07
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ops-sunbeam/ops_sunbeam/test_utils.py
View File

@ -360,7 +360,7 @@ def add_identity_service_relation_response(
"""Add id service data to identity-service relation."""
credentials_content = {"username": "svcuser1", "password": "svcpass1"}
credentials_id = harness.add_model_secret("keystone", credentials_content)
harness.grant_secret(credentials_id, "my-service")
harness.grant_secret(credentials_id, harness.charm.app.name)
harness.update_relation_data(
rel_id,
"keystone",
@ -378,12 +378,10 @@ def add_identity_service_relation_response(
"service-domain": "servicedom",
"service-domain_id": "svcdomid1",
"service-host": "keystone.service",
# "service-password": "svcpass1",
"service-port": "5000",
"service-protocol": "http",
"service-project": "svcproj1",
"service-project-id": "svcprojid1",
# "service-user-name": "svcuser1",
"service-credentials": credentials_id,
},
)