openstack/training-guides
Code Issues Proposed changes

labs: quotation marks around variables

Browse Source 
It is generally a good idea to keep variables within quotation marks,
even if we don't expect the value to ever contain whitespace.

Also, it makes automated test tools (shellcheck) happy.

Change-Id: I1c323a1dd10087694312892eac3c11cf54e07ce4
This commit is contained in:
Roger Luethi 2014-08-14 10:51:56 +02:00
parent be3f838947
commit 269d59d62b
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
labs/scripts/setup_neutron_controller.sh
View File

@ -61,15 +61,15 @@ iniset_sudo $conf DEFAULT auth_strategy keystone
# Configure AMQP parameters
iniset_sudo $conf DEFAULT rpc_backend neutron.openstack.common.rpc.impl_kombu
iniset_sudo $conf DEFAULT rabbit_host controller-mgmt
iniset_sudo $conf DEFAULT rabbit_password $RABBIT_PASSWORD
iniset_sudo $conf DEFAULT rabbit_password "$RABBIT_PASSWORD"
iniset_sudo $conf DEFAULT notify_nova_on_port_status_changes True
iniset_sudo $conf DEFAULT notify_nova_on_port_data_changes True
# Configure nova related parameters
iniset_sudo $conf DEFAULT nova_url http://controller-mgmt:8774/v2
iniset_sudo $conf DEFAULT nova_admin_username $nova_admin_user
iniset_sudo $conf DEFAULT nova_admin_tenant_id $service_tenant_id
iniset_sudo $conf DEFAULT nova_admin_password $nova_admin_password
iniset_sudo $conf DEFAULT nova_admin_username "$nova_admin_user"
iniset_sudo $conf DEFAULT nova_admin_tenant_id "$service_tenant_id"
iniset_sudo $conf DEFAULT nova_admin_password "$nova_admin_password"
iniset_sudo $conf DEFAULT nova_admin_auth_url http://controller-mgmt:35357/v2.0
# Configure network plugin parameters

2
labs/scripts/setup_neutron_network.sh
View File

@ -38,7 +38,7 @@ iniset_sudo $conf DEFAULT verbose True
# Configure AMQP parameters
iniset_sudo $conf DEFAULT rpc_backend neutron.openstack.common.rpc.impl_kombu
iniset_sudo $conf DEFAULT rabbit_host controller-mgmt
iniset_sudo $conf DEFAULT rabbit_password $RABBIT_PASSWORD
iniset_sudo $conf DEFAULT rabbit_password "$RABBIT_PASSWORD"
# Configure network plugin parameters
iniset_sudo $conf DEFAULT core_plugin ml2

2
labs/scripts/setup_nova_controller.sh
View File

@ -59,7 +59,7 @@ conf=/etc/nova/nova.conf
# Configure RabbitMQ variables
iniset_sudo $conf DEFAULT rpc_backend rabbit
iniset_sudo $conf DEFAULT rabbit_host controller-mgmt
iniset_sudo $conf DEFAULT rabbit_password $RABBIT_PASSWORD
iniset_sudo $conf DEFAULT rabbit_password "$RABBIT_PASSWORD"
# Configure other variables
iniset_sudo $conf DEFAULT my_ip controller-mgmt