Add slide #16 of upstream training
Change-Id: Ib5e47c81b01089f92074af2d9630022b390e0409
This commit is contained in:
parent
8ddb22c56d
commit
5127f14427
45
doc/upstream-training/16-reviewing.rst
Normal file
45
doc/upstream-training/16-reviewing.rst
Normal file
@ -0,0 +1,45 @@
|
||||
Review unified
|
||||
==============
|
||||
|
||||
.. image:: ./_assets/16-01-review-unified.png
|
||||
|
||||
----
|
||||
|
||||
.. image:: ./_assets/16-02-review-unified.png
|
||||
:width: 100%
|
||||
|
||||
----
|
||||
|
||||
Inline comments
|
||||
===============
|
||||
|
||||
.. image:: ./_assets/16-03-inline-comments.png
|
||||
|
||||
----
|
||||
|
||||
Draft inline comments
|
||||
=====================
|
||||
|
||||
.. image:: ./_assets/16-04-draft-inline-comments.png
|
||||
|
||||
----
|
||||
|
||||
Regular reviewer
|
||||
================
|
||||
|
||||
.. image:: ./_assets/16-05-regular-reviewer.png
|
||||
|
||||
----
|
||||
|
||||
Core reviewer
|
||||
=============
|
||||
|
||||
.. image:: ./_assets/16-06-core-reviewer.png
|
||||
|
||||
----
|
||||
|
||||
Exercise
|
||||
========
|
||||
|
||||
push a wip or draft and invite reviewers
|
||||
|
BIN
doc/upstream-training/_assets/16-01-review-unified.png
Normal file
BIN
doc/upstream-training/_assets/16-01-review-unified.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 86 KiB |
BIN
doc/upstream-training/_assets/16-02-review-unified.png
Normal file
BIN
doc/upstream-training/_assets/16-02-review-unified.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 290 KiB |
BIN
doc/upstream-training/_assets/16-03-inline-comments.png
Normal file
BIN
doc/upstream-training/_assets/16-03-inline-comments.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 46 KiB |
BIN
doc/upstream-training/_assets/16-04-draft-inline-comments.png
Normal file
BIN
doc/upstream-training/_assets/16-04-draft-inline-comments.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 80 KiB |
BIN
doc/upstream-training/_assets/16-05-regular-reviewer.png
Normal file
BIN
doc/upstream-training/_assets/16-05-regular-reviewer.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 31 KiB |
BIN
doc/upstream-training/_assets/16-06-core-reviewer.png
Normal file
BIN
doc/upstream-training/_assets/16-06-core-reviewer.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 38 KiB |
Loading…
x
Reference in New Issue
Block a user