diff --git a/doc/upstream-training/16-reviewing.rst b/doc/upstream-training/16-reviewing.rst new file mode 100644 index 00000000..71589048 --- /dev/null +++ b/doc/upstream-training/16-reviewing.rst @@ -0,0 +1,45 @@ +Review unified +============== + +.. image:: ./_assets/16-01-review-unified.png + +---- + +.. image:: ./_assets/16-02-review-unified.png + :width: 100% + +---- + +Inline comments +=============== + +.. image:: ./_assets/16-03-inline-comments.png + +---- + +Draft inline comments +===================== + +.. image:: ./_assets/16-04-draft-inline-comments.png + +---- + +Regular reviewer +================ + +.. image:: ./_assets/16-05-regular-reviewer.png + +---- + +Core reviewer +============= + +.. image:: ./_assets/16-06-core-reviewer.png + +---- + +Exercise +======== + +push a wip or draft and invite reviewers + diff --git a/doc/upstream-training/_assets/16-01-review-unified.png b/doc/upstream-training/_assets/16-01-review-unified.png new file mode 100644 index 00000000..b9eaa0e4 Binary files /dev/null and b/doc/upstream-training/_assets/16-01-review-unified.png differ diff --git a/doc/upstream-training/_assets/16-02-review-unified.png b/doc/upstream-training/_assets/16-02-review-unified.png new file mode 100644 index 00000000..6d5f6a64 Binary files /dev/null and b/doc/upstream-training/_assets/16-02-review-unified.png differ diff --git a/doc/upstream-training/_assets/16-03-inline-comments.png b/doc/upstream-training/_assets/16-03-inline-comments.png new file mode 100644 index 00000000..7c04ac69 Binary files /dev/null and b/doc/upstream-training/_assets/16-03-inline-comments.png differ diff --git a/doc/upstream-training/_assets/16-04-draft-inline-comments.png b/doc/upstream-training/_assets/16-04-draft-inline-comments.png new file mode 100644 index 00000000..819290d0 Binary files /dev/null and b/doc/upstream-training/_assets/16-04-draft-inline-comments.png differ diff --git a/doc/upstream-training/_assets/16-05-regular-reviewer.png b/doc/upstream-training/_assets/16-05-regular-reviewer.png new file mode 100644 index 00000000..d3e3fc89 Binary files /dev/null and b/doc/upstream-training/_assets/16-05-regular-reviewer.png differ diff --git a/doc/upstream-training/_assets/16-06-core-reviewer.png b/doc/upstream-training/_assets/16-06-core-reviewer.png new file mode 100644 index 00000000..1b3ab0ad Binary files /dev/null and b/doc/upstream-training/_assets/16-06-core-reviewer.png differ