From 59329b5320ffdd42e5cb24ee0962349eb16b4b45 Mon Sep 17 00:00:00 2001 From: KATO Tomoyuki Date: Wed, 26 Oct 2016 21:49:20 +0900 Subject: [PATCH] [upstream] update Git commit message conventions Change-Id: I55b1fbfd20c14c865f7ddf28c9fcc3e752749206 --- .../source/slides/workflow-commit-message.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/upstream-training/source/slides/workflow-commit-message.rst b/doc/upstream-training/source/slides/workflow-commit-message.rst index 801d6d03..91c1de76 100644 --- a/doc/upstream-training/source/slides/workflow-commit-message.rst +++ b/doc/upstream-training/source/slides/workflow-commit-message.rst @@ -34,8 +34,10 @@ Good: new API + new feature Contents of a Commit Message (Summary Line) =========================================== -- Limited to 50 characters - Succinctly describes patch content +- Verb in the present tense and object +- Limited to 50 characters +- Should not end with a period Contents of a Commit Message (Body) =================================== @@ -44,6 +46,7 @@ Contents of a Commit Message (Body) - Explanation of issue being solved and why it should be fixed - Explain how problem is solved - Other possible content + - Does it improve code structure? - Does it fix limitations of the current code? - References to other relevant patches?