From 73417e0b0e2f9cb32ede324d9e7df5cbe21774a3 Mon Sep 17 00:00:00 2001 From: Shilla Saebi Date: Fri, 19 Sep 2014 15:30:08 -0400 Subject: [PATCH] changes to commit-message.rst removed all caps from GIT fixed misspelling of occasionally made other plural and added commit removed extra spaces Change-Id: Ia0ddfb788fa482610fb0c91720885f9aa1cc7947 --- doc/upstream-training/17-commit-message.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/upstream-training/17-commit-message.rst b/doc/upstream-training/17-commit-message.rst index 7dadbb0e..803f688e 100644 --- a/doc/upstream-training/17-commit-message.rst +++ b/doc/upstream-training/17-commit-message.rst @@ -1,11 +1,11 @@ Commit messages =============== -- quality of the OpenStack GIT history +- quality of the OpenStack git history - carrot by alerting people to the benefits - anyone doing Gerrit code review can act as the stick -- review the commit message, not just code -- Developers read mostly, write occassionally +- review the commit message, not just the code +- Developers read mostly, write occasionally ---- @@ -28,21 +28,21 @@ Things to avoid ---- -Bad : two independent changes +Bad: two independent changes ============================= .. image:: ./_assets/17-01-bad-two.png ---- -Bad : new feature and refactor +Bad: new feature and refactor ============================== .. image:: ./_assets/17-02-bad-new.png ---- -Good : new API + new feature +Good: new API + new feature ============================ .. image:: ./_assets/17-03-good.png @@ -104,5 +104,5 @@ GIT commit message structure Exercise ======== -review each other messages on the draft +Review each other’s commit messages on the draft