openstack/training-guides
Code Issues Proposed changes

Changes exit status for heat_network unit test

Browse Source 
If the test fails, it should exit the script not the cluster. Just
reporting this error and gracefully exiting the script should be
sufficient. My reasons for this are:

    * The tests are not completely reliable to say if the cluster is
      broken for sure.
    * The tests are not meant to fix the issues with the cluster, it
      could be a packaging issue or bug in the product. Our aim is
      not to catch them.
    * If there is a problem with heat, the other servies are still
      running fine. And the cluster is still usable.

Change-Id: I246bd3144189eba69a64ad545e6fe123e310595e
This commit is contained in:
Pranav Salunke 2015-05-06 14:43:21 +02:00
parent 2fe7df2835
commit e05cafe19b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
labs/scripts/ubuntu/setup_heat_network.sh
View File

@ -68,7 +68,9 @@ until node_ssh controller-mgmt "$AUTH; heat stack-list" 2>/dev/null | grep "CREA
echo
node_ssh controller-mgmt "$AUTH; heat stack-list"
echo "Heat stack creation failed. Exiting."
exit 1
echo "[Warning]: Please debug heat services on the
controller and network node. Heat may not work."
exit 0
else
sleep 1
echo -n "."