diff --git a/doc/upstream-training/source/slides/_assets/workflow-reviewing-wip-patch.png b/doc/upstream-training/source/slides/_assets/workflow-reviewing-wip-patch.png new file mode 100644 index 00000000..aa90e66c Binary files /dev/null and b/doc/upstream-training/source/slides/_assets/workflow-reviewing-wip-patch.png differ diff --git a/doc/upstream-training/source/slides/workflow-reviewing.rst b/doc/upstream-training/source/slides/workflow-reviewing.rst index 9eefa21a..10dc8940 100644 --- a/doc/upstream-training/source/slides/workflow-reviewing.rst +++ b/doc/upstream-training/source/slides/workflow-reviewing.rst @@ -46,3 +46,23 @@ http://docs.openstack.org/upstream-training/workflow-using-sandbox.html Try to find things to make comments on even if they are just asking a question and not pointing out an issue, don't just +1 three different patches. + +Work In Progress Patches +======================== + +.. image:: ./_assets/workflow-reviewing-wip-patch.png + +Work In Progress Patches +======================== + +- Multiple ways a patch can be indicated as a Work In Progress + + - 'Workflow' is set to '-1' + - '[WIP]' is at the beginning of the patch's summary line + +- Developers often do this to share an early preview of what they are + doing or to allow for feedback during development +- Patches may be reviewed but should be done so with the fact that + the patch is still being developed in mind + + - Don't -1 for spelling mistakes, wording or missing details