From f5797bdc85061b3be0d735fd513c1c624d6142e6 Mon Sep 17 00:00:00 2001 From: "Jay S. Bryant" Date: Tue, 24 Oct 2017 18:19:52 -0500 Subject: [PATCH] [upstream] Add slides on 'WIP' patches to Workflow It was discussed after the class in Boston that we might want to add something about 'Work In Progress' patches in the workflow section somewhere. After looking through the content the best place to put it seemed to be in the 'Reviewing' section as that allowed to tell how a 'WIP' could be indicated and then how that should be handled from a review standpoint. This patch adds a couple of slides to cover the topic. Change-Id: Icf77b248e4cfddf1d6efd5fa1d8b0a94fefdc76d --- .../_assets/workflow-reviewing-wip-patch.png | Bin 0 -> 10182 bytes .../source/slides/workflow-reviewing.rst | 20 ++++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 doc/upstream-training/source/slides/_assets/workflow-reviewing-wip-patch.png diff --git a/doc/upstream-training/source/slides/_assets/workflow-reviewing-wip-patch.png b/doc/upstream-training/source/slides/_assets/workflow-reviewing-wip-patch.png new file mode 100644 index 0000000000000000000000000000000000000000..aa90e66c842b3346739bfcbf478253659150da83 GIT binary patch literal 10182 zcmbt)2UJt`$)4RsYm03fpj zfHQ0t&Vf6$W#)(A<=i7JH5K6G^e?x)BnjNP=%H@r4FELVr~hYq-Af;Xo9BHrbX3nT zP_kTMXS?>PW(EK_0S%S=kbo)tOsGC&pR~C>L0JjSwNb50&s|cBoyquEyQZJgjNujI zP15G2d(-^kp<25{wuV=>J9-^|ud7s~eQGL1Ov5q1SreHu*u$aTmoEA?ub>^nT>MZ+ zyG-)8dTxJl#GRVlR{NLU*(F1j@&gw4}EH!1lLxHm~Z6e36Fplc!0Kjo*8D z4PwV9hKN(vbBL_0%Bh`xV_a>e>;jF;C*rkD((*{K&nxeX0HA&N-gluwS6wqRt+a6h zwcZ@bjYPGWW2zN-+gmh(g#vO+t0M!I419f&e)5LZ3Z1ffk``jG=4=Yopw&j34I0j9 z8{G-51OX=cH~`31N($E8b`NggbxPP&n@HGO@8fcnH82n+RVvPlA_MGGwD>!-pG1}i z3a!N%9mNnW8Xq#j4sVUUN|o%J$u|m3x-NLz?F@lBNQp~Gt zBs}_~?=^wrZ5jnWZ=KYR6MBV1LJ4M}VQ7Moz3gQGpdK8ZT@$_YJrcgV0M%F|q8PBCHFT;q^*UP6SKmKq-PMe5 z-U=}(y>~Ulq&j198yS3vO#}dyj3<${>C@Z|1hrs@@Y<;BB7GwO+#<<*Ue9s}Lc#^L;OI>_~fwn)9NmogQ&!^18!G&+uG*m8odd5_-j5_m4& zKmNe_k24ZZ1(G;DGGTJPcFdn%Sc=b$VrEu4P`Yiym&pNJ%AkYM&HZL~zn_CICy!qe z(TWrl6j{EY%iKswNx9rftIbRHZ^wkLscYjWO_XuFAAFv>-Re$McU~RpR*)Wa*|aD+ zbu=!e+n~5U=|H9Pc#2QPFKdaN7U1-_L?m1H*loVVT6ckhegf;@#Q@>ix?pXh`eBu9 zX_ee{EAVQ(#}sNtUD5vxkRzf;0_G3FNB#8V^?9Ww;i$_M2 zTl`#mq@PA+tUc1ZWwX?^H^qga2@%icZxjvJo6nAhwmSJsL-rcmH$#pH8z!aj>&5kQ z*Z6{6Uwd8~>u_?$IIle`AgrSXeth$kv<=1Ex#W7TdQboCb$jhcJ~Eo?Hz&lFdy~m0 zME4i3Gtguo&i_@ad+up3Wda|;UOCcJC#vBg@flNUGhfB7vETzsm4S)Xyn5rM4TgSTM_hyXPkC2Slmy6c(@*3qF7wJs#O|4t$@uYT7b;hcw ziU}zp9*i;+c?R0|X&>}2!m(&NF&i2*NcrU0zGKus&*s=tpC>?3IsP#2sLb=LtnkLq zz&oJY4#%a3ln_vk^R5%?%2TV^8`j2;DL&@KDVNg8d9;pAqN2(9D&m)V#)9LRnsC0Ab|c;HuyUyzo z8&9{TwAvX5vmy=N(q4zU#uQ@8G%xkixGK@t@%fz(<*I?kb}^Er@q4!p=Kl2fT>HC? z1}?wrY*f~s&jQhqm^fkyGSeeuKiV_aiqppINkM7B81SN@;xqL_awzS&Uwev`qkIm- zNngiGcY+2{SJ#eUorazs?=|3`jSXr{XzwDOeYd}qENyH_iyxEHcWn{Ad5Y!mh~CI= z1_(ow923{T0>e%*lL3wpb+rMQ@2s^Q@4n5Ck<{wZTKwDYjFt@IfkAelN8CpIH@)XH zcWDF}k1)Zyqbx3Oux#SyiHqcuZo(a2ouG<5Fqa1QK+{I*807^XR_ z=dHx}4pO=gY(4HQ3Df@x|{fd_=QZ#({{@hLCiZuTjmE!(>O@-g9`^0IE;c3zFbi=cE zp!3d<`Li3o5*^$Mjhrd9XTs!oGHw8O-Z-er*3aZoN4ZAK?}^>Lo-^W(OIe}0uFuSP~##gzWqOJF)8SHXmj~Y{W zRl$t%2Y>w|xBMr|{}il|F)4%e|H)<8dkO&X=v5IrmEwx8k1zcxn)@{N^V{3Y^_Bl4 zJ23+=@Y8!Lk4EJ|j+yOGFaI%2{3E5x&W|L$D}Nqw*9AXWA9ecpd*5!J>aXkSsl>UR zH9e>KHB6MoqGI7xnJ$-4@3)INy|uV)-a~?=JN34z+SEA{V`DErG9c{bcMtzIu)%9^+(XupPB1lk3 z=%V+)icbrKuiuhSL-WM0xlT(jqOu=~5_^cFK}EDFDen9g9qla*s*H^3&dcN>1W0gl zPy~gYs?h2;_@%HXCtTX>8@tb4Z;a1o47wSoOa)x%d=d%VTF|zUjjR+l@Jb|fYV?`Q z(-4ysi;3g_GZm=VvqH9AtM!unI@@fw%T&1KP(0a}$--WW%lSEebm2FOW|pu1xf}9G z#4$_pgHz@M7uWHkQOUFpRebh!*yWDo_RbGSZ)+$3W)4V`NPzX^x&d+Ab6wyEL%wVD zWe{+wL{QNW8dmaDjTg^l+E5tm6A1`jYYi?+fNr$Z!>&tX&b&OoNxLUab6K{$$j${@ zKu#?R*k;L4cZ+n5>Z_Ufn=)0aj&ak1etGb}^2;#ZI3@gZyQi*hiCDZbszfVMTwL0*rxj?t+sKbYP3A2^K zYS}q(M8j7GL5oK1fmA^wbLVJTB_d>VyuE-;LBXgk!F!7R*FnSD=P8kFa?m~#P371k z(5g>EpHImtfR--}361Z+Yu~Wpfz8HNeK()mYw(wR;{Fbj+N|~FSvzUIJw`K~zB+=6 ziBCvKmnKRXe0h3$nm2jmU0ME!d%iC;7IizNBllM2??o~oogo~T<>%y<6br6iSGFLg9&WJtiqD?*f`_a$ND0?21ye3qr$J?Wk6txe25y^QCKhsla-$T`Zf zEJsrK--OoK5Nn%{Hn29SB?s>pE$8&{3@$@VkD+9|wh z!8p)1mSxMAF!w+3=wu=^ed^E!dq-XlX^u4BEp<92Fa%f16V)S5*E^LEzju)Og)j-y zlXl5!OTEG@@tQiq{xqBCm-*(Xh?j&oxKCVwyw+AnWq6&)AHz8hFuTl>q$H*Pgx ziWqQ0+9%3yv-m!{-;ymgy|=RdelXIy>h;1tXjbc*VV#62SlTx} zr6t=(cz`;t$1YV+s&qnf5$~wU`i%LN6QZnUS0r0?km5EUdyC_QI z7)f`7OzTJ%Ka}L`tlL-VEo;TcD{R7_I7qcbPxN+Sd|`wrON6u;t|cnbVX{~QT1v&y z#wlBo`GSsYk&!DCeu;}#1O7BNQz>;hv>Rh7_Cx~R8GFM76@oL2tJisvSLVcouB?-r*w=}U#|IbAzc z+2OA*#a%^3LE{L03O(AEOraNw)fL_$HT~6Tt!sZlKr@Be(47mmIRixUd+}S|M?2;f z@yJx?MEx>M&PuN6N%UzBoR5aSFQHNB(Co5>wPuxv7PJQ@KB!!|I9VL{MxxwEc-2Yy z;zJVBK5nFl)%^+om*_`jj>^T71QQ8d@3j&mxBYpo_cLy&W$El&vRQkImO^P>-rh*t z4`hO-HTRmEo4uMX?eM33-!lvkX;xBm5WZeRv8%#0r}Qn5?OIEPy~QT2$8a(i>1^mu z7KgK~SFymGUv21wW9-MnFBie$&4!3~cI;o{B>_ygGWX4le4sdjoO?>%Mwp<7=|b^( zlP*egOolYv5jl`iyrZ*!R=`{ja(o}F%J+l&JblVZjF*EJVsa~I`O%Lv*oL~tj;{)x zF%S*a5r!8u51%*MZ&>I+k%e5Ex`~PCHgwT*$k1Pfv#s|O6r_CcQ^=4UZ~T-5VRu@8 zy`AczkN9(yIeQG*>;ndxr|1YwkxXQ zET2Zt&3Cqzju$wg+nL%ZG3EMIgUl%r0rGIz^F3=_^c|B}$ugDT{T20&FDa$JpI;iA z5_jlvt>?2}LU0UE+`Y}Xnnp}0cT`47lG+UUX|7Vw7DKZsO$+Gx1}}}pv(z9+Ogpib z4&~+&-RZi?g`m%^cDM_SVLC%N6MAozpw}#(&0;WIC~W1scWf=2Y%${YpJFew_xFvd zeO}zvekBQYrIL2X?KAZ=GKp=;q(E}Xkvh@-Jx`K+P4t zg`U3zT~_!b`Qs1qTLP1Y8G_AE(CdI8S6Kp(?P%VpX6-%j)YnWN^EO-Cnt1o2Vw{-8jqXL zssJ;{LH0`I)<-Ki@hmWHaM^r86Y`6ch!84mhHC01Li{xy#tS4a=_Fp^LY5uY-4-

H24sN)k&W|c$3H2J06ZUe*=H6+dRCy9-NEczcVl~m5h%Y!?$Kt6?X9s z^eqXs$yuod85u@i)k3e)M?JZRUh#E1jcYzLSBpw4R)*d#BKig}!bu0`F8~j3B_3~h zebnW>Q?jIvFdlj@$)~*Ixt6BhPI1^% z!r1Hb2D%?h&fG^Q%;v!H4aUw^mUFxaxxA$U$Ds@fEh+ceuRSqLzNcuQ*-P~l9K5-u z<^y7dnYKWqddDHd0kxrm4f|Z|lOtwt5ZMaUuk)F$%#r#uM?R-G>zb`(nE6^|B{KiY z+SOCbL@&4cZ&1n$x1Ez!axsct7XKk+!9mh<$QY??D8@Z6et`3f2yov;;g9kAd(FX4 zd7C8TQ}pe(F(yk4{xX%Lk7eGvUf1bFZY?HL^6QND^*2P`p2Ek1d(irfua;bE$B&ns zQb7alDE%l8ddq|YQDItHU7HuiKj`c1WNy2;u*sHr8iGpmI0DS!jQx6)Z7-W8AzD31 z*&11cVGJW;F6UNXmZ8gBi}();fpYP`Arufjb~f}mSTnbUZyOqAR2gU;>vcuS$fNwCbq7)f)1~ z5VgWUZlU>%YqR=^Wm-hGud{0g!LG0R?~->voLpkqd4|lf0VC~-Y}L=81e%KLU55ri z_xr|W0_vK~Gec(QGE_8*aG2k*`_0&72U=+;w$Q03mSntM46o)CO1P`xK$?;`<+M3ZhUHK3e4Gw^@r=^|H|Qg)1Xs=Kha!S za#r1%%0Ljj9NdzA^+P#snnw8PmS}M?y6;g)t*j66)ivs9@TX*Rdk-b-H~%tO8Fb~y zL^?6c^*xp8K)`mEu5ryR(monGsTo$@WbnuFVjz469xR_2Lr4=pDM0!?=|*OUZI8ijfKPpnyeutU-Hq1d$bSET!-sggsSZrR{?^<*j@ zZick(tUp$Q!)!kb1dmd_(4dh0(i~Al4#v=hv{J@NnZ(AmA|_$=Iw3dX*P}~JyM|?j zZ46vm;jp&90?M_YQ#Kt?=OfM1j)H%B)lbjjtHHAtRVmWcX*qf7Y;AU~k17;0MeU1Q zDiC9T2R2q#RvDu9%cVr-&*15x9R_ogjaw?#ymRT&=Gt2>zH$X_e>BAj!@g1mL~L5$ zii@`zv~H-Ii{Je5FazOi;m}XK_{kabO^9=LCGze;M4k#aZb(G@2i43yCjL!H zhaY?v7(`jKtud`}rd_Ro7}};b69CbUSL=}0+kquRH@B**0;ahXR9AVVq)dd;2HHGY zW-=Ci;#(5V2oD#m+FRb{f_XxdGAaoc9fIwkd!%Lhw%k8Pd{N--Z>&CKjs89)>rrE@ zTJ+Yw-mx!Z?D}q6rnWsf{zLpYcuF$-~l>SD&8{_O>iV=Ag zSPO&`Ov~lNtymZ6bjw_|iB2i+-hEKI+3^EK9uM74to}@B&Kf`Tai-+1P~@DI6FmK+ zar517v*^T13gYp8KFhC2b0~S(_SMNb@l7g$`xs9CmzaPOmUgDHVRK#~qpBu?@oPR4 zxYLK%O7Au;+s#zj5YW9xMen3dMOJsvs30Fh(S9!wn%wTQytio+yjc0^aAI9rOsjCr zm43Zkz;Q4=kJwSGZgO%IE`L2COSi;5JlMn}ZQ2bL6y){?7saxO-ErYql>x{ja0!Vk~GFxS$G4=#-hUqHUgs~pm_DQORU+CSBN_s4n3hZO;@GOR!t z^x&i~WR8Q}z15rG-hjF@6jYt^Wb^piTdtK5vd8e|@x!B(x_v1yCu^)R%1+WPhK}%o z5f$~Bmk<~SLZ;!HLI8bow+QvEYnMQL6h$D4+*}(NEdJ}?QPN*y{{tnx*dQl?KROEp zFp*O4&8DNMmYl!I-*F{RZ@IY^+ypkDm=jA&c}|lUxvdTaq#jQ<@xr$wd~m6;7VTrM%6HwgB5!w#xF?=;Dld4v2K4XG2e389n&zWXF=W%aN)j zbmCJ0DyJiZ00oMLiW$O3&sJekzB}L8)@Ag|W|yz7?FdIQy}N_&6o`Kl_gqRmk}?)u z{5E`hz-I6Kr<0fHh8F=ktxi?>o$rcQxoCO#o(e6}YF`Fxbw;C=)?KN>uUHF$v-dmO z8>9X@#sy3BX~tJ;Po$+P6h3|B|8z>>mDjg&I3RLH+x`Ne(lBey(%v3R4wk$`xKz|A zstU+}_rb4hFN7I*NHesrD#DjKSEdhDcZ{Hr7y>@B(5((>5Hci`YV)mn_j@~*|EtJuMeB-!&hk8YbLVBD?p3ZJ@>>c84H%jYQbnTesP0)bNeHh3HzkWFhJ=_+y5*Z>NtD0c!eUK=*k2 z{_KFQ`q5T5Ew>di;cxBtstZ!HMkxRgJFpaoV+)7fq!5gHUJEujTXL7?k0b?tZ##2D zS!iRu$qq|IMQay* z!!?@T_xEv0NqiyBIfgO(NKa9mTIbgzF zogCo2W~aqQFmx#5XALvVD7(itMrK|epM}^`~{6)M~9 zr4fARrZ9bjG@l!IbE(SfNw@q7|6I_AFTLg0f&v;3cOr*qhB!(MADUeSM9kBi8#dP; zxIUB7(!~j_+$usm`*@PPf1(%O*!h&?G54??lFC(r;v=*RWIx*}y!~|HC=GJ-vVIfR zvERmb(n}8CKq-Yb+;FYS@4|$prokEu-NalJ>c^=q+}lB!O1MT`){xNUo$K$MC`8Kn zQfoD3L%x2oU{7?@Bu2>zUIgBYG+VH774emIu61h>8%RR}3N~hC{b^Fp3m7<}`A6tM zVJf1o&Tu4Duf@>1V4tgbj%R#NiphC#U>r6(T?J38AhK0zP7SaX{VG9jUg@>v1fAp8 zFh@dBdLRwSuKr{NMZ?;$we+<1FLZ09(mZhx6%er0wk_6#M9WgN&z0!_=U0)%s1 zuQUMMnIP!INFnNe!SVb&U;J=Y5Nx;EoFu==aA8Cvoxf^}dqGEF+HHrjhPzsc7ThPB zjBD$R3RX2EbN9+EK3Up-PaqG6c`SO;$qPnaSCVa;VCa0LPAj(?rJ7i*#TN4OwYBKE zsW%suXn?TKEgdpRhFlT|0{vPz9aLzattY7EcXVAeKQs^}6DQ3#%d0_z=Xk(zdXM#Z zhJ=X|#WIX71QgXXfCPO`Y?!H^J=KG}L9wxvNgFMYu`B zW~XkyE0q}q#d3b2KaNqu%)G^P40+Xx#qgyCj}<9tmZXw6xNf@5HYRnFi9gmNK7;3m zzG;6FaxG~q=KLkD<8OIUApM%hRg<#Lk+mg?9;>u5zm49c>1NuHzrno`5591E$}cpv z#r-&1h8Rz38IGbG%M`H_4}Q3O?ULGm8vH?Hts}ymr>qtuIHPbcCLwwKaGcCF6mgGu z+k5o)EnSThBes({^pw*~rw2*Pk>f?xaYEVU;t>}=A72kmwk~TU^KeG zeBTcDYIFDzC&1Y?EKRZ4Dwmcnz`qK^j!xwPci~6$^ zF;mrRxD-Udn8@&*Zb_tG6*MnYjk)Rx&UL*nT=>`CQ_^LyM|Gj=|1cl&FFm|l^h0#E zw-q~mwWJg~i)OJX7HS^nDRKDH!03^e_(>s%lBw)Q;XB^&ka82dBT6Z4vUZevIdPe( z1rux`RucO5%$YDwZQe(wAdQ%sh}YEJUsg~-gu_Y;(86?0BCH@?)o)#4dALt2pqMXf z-uoIm&_rG9uy{Kh-%y4cc=-DWS6x}>`W$bppNA`$>1L+^=SZ?m3p%>FY0?J!P&Qzamy;P^v7v(74O945+VXo_aX?_p8Y z#A?|@l^%lrJ2>=m_Z`Pt3Ng7qS_^VoPhPA;%JdIoi_!P9F&MX)us3e#H#r<8d%~1I tu61)tByVMQAdUN{C3JhKf#Tv5+K^9D%-*fs#h@(#4OLy0st2}z{TIz(7Qg@i literal 0 HcmV?d00001 diff --git a/doc/upstream-training/source/slides/workflow-reviewing.rst b/doc/upstream-training/source/slides/workflow-reviewing.rst index 9eefa21a..10dc8940 100644 --- a/doc/upstream-training/source/slides/workflow-reviewing.rst +++ b/doc/upstream-training/source/slides/workflow-reviewing.rst @@ -46,3 +46,23 @@ http://docs.openstack.org/upstream-training/workflow-using-sandbox.html Try to find things to make comments on even if they are just asking a question and not pointing out an issue, don't just +1 three different patches. + +Work In Progress Patches +======================== + +.. image:: ./_assets/workflow-reviewing-wip-patch.png + +Work In Progress Patches +======================== + +- Multiple ways a patch can be indicated as a Work In Progress + + - 'Workflow' is set to '-1' + - '[WIP]' is at the beginning of the patch's summary line + +- Developers often do this to share an early preview of what they are + doing or to allow for feedback during development +- Patches may be reviewed but should be done so with the fact that + the patch is still being developed in mind + + - Don't -1 for spelling mistakes, wording or missing details